[#88] feat(window): Active 윈도우 z-index 구현 및 prop 전달 구조 개선 - #92
Merged
Conversation
- Window 컴포넌트에 isActive prop을 도입하여 z-index 기반 활성 상태 강조 기능 추가 - pointer down 시 창 활성화되도록 로직 개선 및 windowId 전달 처리 - Friends 컴포넌트가 props를 수용하고 하위로 전달할 수 있도록 구조 리팩토링 - Window 관련 타입 정의를 정리하여 일관성과 타입 안정성 강화
github-actions
Bot
requested review from
RumPumpumpum,
stupilman and
suyeon1104
November 18, 2025 01:34
RumPumpumpum
approved these changes
Nov 18, 2025
RumPumpumpum
left a comment
RumPumpumpum
left a comment
Collaborator
There was a problem hiding this comment.
코드 확인하였습니다!
고생하셨습니다
There was a problem hiding this comment.
Pull Request Overview
This PR implements active window z-index functionality to visually distinguish the currently active window and refactors type definitions for better organization and type safety. The implementation adds window activation on pointer interaction and passes windowId through component props.
Key Changes:
- Active window state management with z-index based visual indication
- Type system refactoring with new
WindowInfoandWindowInstanceinterfaces - Enhanced prop passing with
windowIdadded toWindowComponentProps
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/types/window.types.ts |
Refactored type structure by extracting WindowInfo base interface, adding WindowInstance type, and including windowId in WindowComponentProps |
src/stores/useWindowStore.ts |
Removed local WindowInstance definition in favor of imported type from shared types file |
src/config/windowInfo.tsx |
Updated to import WindowInfo type from types file instead of local definition |
src/components/window/Window/Window.tsx |
Added isActive prop to control z-index for active window highlighting |
src/pages/os/OsMain.tsx |
Integrated active window tracking with store, passing isActive and onPointerDown to Window components, and forwarding windowId to child components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 개요
Active 윈도우 z-index 구현 및 prop 전달 구조 개선
✅ 관련 이슈
🛠️ 상세 작업 내용
📸 스크린샷
N/A
N/A
👥 리뷰 확인 사항
N/A