[#87] feat(window): 친구 홈 윈도우 추가 및 윈도우 관리 구조 리팩토링 - #91
Merged
Conversation
- friendHome 윈도우 타입 추가 및 아이콘/설정 구성 - windowInfo로 정적 윈도우 정보 분리하여 관리 구조 개선 - WindowStore는 윈도우 인스턴스 정보만 관리하도록 리팩토링 - Taskbar와 OsMain에서 WINDOW_APPS 기반으로 UI 렌더링하도록 수정 - 데스크탑 표시 여부(isOnDesktop)에 따라 바로가기 아이콘 렌더링 - 친구 검색 시 현재 사용자 제외 처리 - 검색 결과에서 friendHome 윈도우를 열 수 있도록 기능 추가
github-actions
Bot
requested review from
RumPumpumpum,
stupilman and
suyeon1104
November 18, 2025 00:48
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a friend home window feature and refactors the window management architecture to improve maintainability by separating static window metadata from runtime window instances.
- Added new
friendHomewindow type for visiting friends' minihomes - Refactored window management to separate static configuration (
WINDOW_INFO) from runtime state (WindowInstance) - Implemented desktop visibility control via
isOnDesktopproperty
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/window.types.ts | Added friendHome to WindowAppId type and isOnDesktop property to WindowApp interface |
| src/stores/useWindowStore.ts | Refactored to use WindowInstance interface and reference WINDOW_INFO instead of storing full app configuration |
| src/config/windowInfo.tsx | New file containing static window metadata (id, category, caption, isOnDesktop) |
| src/config/window.tsx | Updated to compose WINDOW_INFO with UI components and icons for each window type |
| src/pages/os/OsMain.tsx | Modified to filter desktop shortcuts by isOnDesktop and retrieve app data from WINDOW_APPS during rendering |
| src/components/os/Taskbar/Taskbar.tsx | Updated to fetch window app data from WINDOW_APPS when rendering taskbar tabs |
| src/pages/friends/api/searchFriends.ts | Added userId parameter to exclude current user from search results |
| src/pages/friends/Search.tsx | Integrated friend home window opening functionality and added missing key prop to list items |
| src/assets/icons/friendhome.svg | New icon asset for friend home window |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 개요
친구 홈 윈도우 추가 및 윈도우 관리 구조 리팩토링
✅ 관련 이슈
🛠️ 상세 작업 내용
📸 스크린샷
N/A
N/A
👥 리뷰 확인 사항
리팩토링으로 윈도우 관련 구조가 많이 바뀌었습니다.