Format the elapsed time of test stages#862
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The summary table of the system tests currently shows the time in seconds (and deciseconds). While this is quite accurate, it is not very intuitive.
This PR changes these tables to use the same format as the GitHub Actions summary page:
1m 59s.The total number in seconds is still sometimes useful, as it is the one that we use in configurations. But I think that setting up a configuration comes second to just getting a quick overview of how long each step took. I tried appending the time in seconds in parentheses, but I found that it was bloating the table too much.
I have tested it here: https://github.com/precice/tutorials/actions/runs/28819714730/job/85484164927
It took me some time to make the formatting (almost) fine in the ASCII table, but I think it looks good enough now.