Add monolithic tutorial cases to the system tests#861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following monolithic tutorial cases to the system tests (related to #448):
These are not coupled cases and thus do not generate preCICE export files to compare. It is still important to know that these cases still run, though.
There is a check that a test selects an option from all participants. This is useful for the usual coupled cases, and makes the code simpler later on. To not touch that check, I am defining the monolithic case as implementing the one participant, and providing a virtual (named
none) implementation for the other participant, which does nothing.I am not sure if there is a simpler/cleaner solution, but at least it seems to work. Since this only defines test cases, it would be trivial to revert it in case we find a better approach.