Skip to content

Append failed system test log tails to GHA job summary#830

Merged
MakisH merged 6 commits into
precice:developfrom
PranjalManhgaye:issue-792-failure-log-summary
Jun 10, 2026
Merged

Append failed system test log tails to GHA job summary#830
MakisH merged 6 commits into
precice:developfrom
PranjalManhgaye:issue-792-failure-log-summary

Conversation

@PranjalManhgaye

@PranjalManhgaye PranjalManhgaye commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • on failure now , we append the last (100 lines, collapsible, all stages) of the relevant stage log ( build / run / compare ) to the GHA job summary.
  • stage is inferred from timings ( fieldcompare_time → compare , else solver_time → run, else build ).
  • Closes System tests job summary does not include the actual error #792.

Test plan

  • local quickstart pass — summary shows timing table only
  • local failed run — summary shows ( ## Failed test logs ) with compare log tail
  • added changelog entry in changelog-entries/ 830.md

@PranjalManhgaye PranjalManhgaye requested a review from MakisH June 10, 2026 14:38

@MakisH MakisH left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing! A first run looks good: https://github.com/precice/tutorials/actions/runs/27284473467

Since the job summary renders Markdown, I assume it can also render HTML. What if we display more lines (say 100) and put them into collapsible sections? Sometimes (like in this job failing at run), there is useful information higher up in the other participant.

Comment thread tools/tests/systemtests/Systemtest.py Outdated
Comment thread tools/tests/systemtests/Systemtest.py Outdated
Show build/run/compare logs in collapsed details sections on failure.
Revert footer wording to match develop.
@PranjalManhgaye

PranjalManhgaye commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

thanks @MakisH for testing this , and as per your feedback i have updated 100 lines per stage (better for interleaved run logs) , collapsible details for each run like :
1 (build log) 100 lines

Details 100 lines

2 (run log) 100 lines
Details 100 lines

3 (compare log) if error then mentioned failure stage here in case
Details 100 lines

ofc reverted footer and stage detection is unchanged , also tested locally

@PranjalManhgaye PranjalManhgaye requested a review from MakisH June 10, 2026 16:37

@MakisH MakisH left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread tools/tests/systemtests/Systemtest.py Outdated
Comment thread tools/tests/systemtests/Systemtest.py Outdated
Comment thread tools/tests/systemtests/Systemtest.py Outdated
Comment thread tools/tests/systemtests/Systemtest.py Outdated
Comment thread tools/tests/systemtests/Systemtest.py
Use artifact log filenames, append all existing stage logs in
collapsible details sections.
Wrap failure log tails in a max-height div with overflow-y auto.
HTML-escape content for safe rendering in the job summary.
@PranjalManhgaye PranjalManhgaye requested a review from MakisH June 10, 2026 20:16
@MakisH MakisH moved this from Planned next to Needs review in GSoC 2026: System tests improvements Jun 10, 2026
@MakisH MakisH merged commit 68c423b into precice:develop Jun 10, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

System tests job summary does not include the actual error

2 participants