Remove seeing useContext as HOOKS_STATE#952
Merged
Merged
Conversation
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: d7dfa3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +7.85 kB (+4.37%) Total Size: 187 kB 📦 View Changed
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
JoviDeCroock/signals-rerender-prevention
branch
from
July 7, 2026 08:25
246b62b to
d7dfa3c
Compare
marvinhagemeister
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HAS_HOOK_STATEflag exists so the auto-shouldComponentUpdateoptimization never skips a render carrying pending hook state.useContext(hook type 9) doesn't need this guard: when a provider's value changes, Preact force-updates every subscriber, bypassingshouldComponentUpdateentirely (https://github.com/preactjs/preact/blob/main/src/create-context.js#L24).Flagging context consumers as stateful only disabled the props-based render skipping for them. Common combinations like signals + theme/router context lost the optimization for no correctness benefit. With the flag removed, context updates still propagate (covered by the "signals should not stop context from propagating" test) while parent-driven re-renders with unchanged props can be skipped again.