Formatted text has wrong leading with one line paragraphs - #922
Closed
maerch wants to merge 1 commit into
Closed
Conversation
Since `fill_formatted_text_box` is changing the `y` state of the document even if you do not print anything (box.leading is subtracted) calling this will cause a wrong leading for any paragraphs which have only one single line.
pointlessone
force-pushed
the
master
branch
2 times, most recently
from
January 22, 2017 21:18
3c5df3e to
8309626
Compare
Member
|
@maerch Thank you for your contribution. I've rebased this PR on master and merged it but GitHub didn't pick it up. I will close this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong: If you are indenting a paragraph, but have only one line to print, it will be printed by
draw_indented_formatted_linecompletely. Thus,remaining_textis empty, but Prawn tries to print it anyway. The problem is thatfill_formatted_text_boxis still changing theyvalue of the document if you specify leading:box.heightandbox.line_gapare zero for an empty remaining text, but box.leading is not. This causes a wrong leading in your text if you have single line paragraphs.Example:
Space between the first paragraphs is too large. It should have the same leading as between the second and third paragraph.