Add method to delete pages of the document by index

[davidsilveira]

#958

[sobrinho]

As we discussed, try to abstract to delete_page(index) to be able to delete any page instead of only the latest.

[pointlessone]

I wonder what is the use case for this feature.

[sobrinho]

See #958.

[pointlessone]

@sobrinho Thank you.

I'm not convinced that use case warrants an addition to the library.

[sobrinho]

@pointlessone this is a pattern that repeats over and over again in all projects that I work.

It's okay if you think that doesn't belong to the core but would be a good helper for us!

[pointlessone]

If you want each thing on its own page why don't you start a new page before rendering a thing?

[sobrinho]

Because you can't start a new page in the first iteration, otherwise the blank page would be first one instead of the latest.

In that case, the code is like that:

things.each do |thing|
  if things.first != thiing
    document.start_new_page
  end

  render
end

[pointlessone]

I see but I'm still hesitant since there's a straight-forward workaround and the code is not complex or obscure.

[sobrinho]

Your call!

Maybe there is other use cases, ours is just this one.

[johnnyshields]

Deleting a page at an index is valid request. Ideally it should support negative indexes (-1 == last page).

The use case given is rather weak/inelegant however.

[davidsilveira]

@sobrinho @johnnyshields I've updated this PR.
Now everyone can delete a page using an index value.
This method supports negative index, so if you want to delete the last page you just need to type -1.

[sobrinho]

Awesome!

[pointlessone]

@davidsilveira Please make Rubocop happy. Otherwise it's good.

[pointlessone]

Thank you for your contribution.