Support for ValueTuples#1012
Merged
Merged
Conversation
Contributor
Author
|
Auto checks are broken in master, can be fixed by #960 |
praeclarum
requested changes
Dec 6, 2020
praeclarum
left a comment
praeclarum
left a comment
Owner
There was a problem hiding this comment.
Love this! I just have some changes to make sure we don't break backwards binary compatibility and also so we don't change semantics for existing reference types.
Thanks for the hard work!
Contributor
Author
|
@praeclarum thanks, good points. I'll make the changes, and solve the merge conflict, in the coming days when I have time. |
Update fork
# Conflicts: # src/SQLite.cs
Contributor
Author
|
@praeclarum I've done all changes you requested, please take another look :-) |
# Conflicts: # tests/SQLite.Tests.csproj
|
Is there anything more missing for this to be merged? Would be great to have! |
praeclarum
approved these changes
Aug 25, 2021
Owner
|
Sorry for the delay getting this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1007