chore(test): fix broken e2e tests - #191
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small and localized, with only a minor documentation wording issue noted.
Pull request overview
This PR updates kube-proxy startup behavior by removing the pre-start nftables ip nat flush that could interfere with networking during end-to-end runs, and adjusts related inline documentation.
Changes:
- Removed
flushNftablesNat()(and itsos/execusage) from the kube-proxy executor. - Removed the conditional nat-table flush call during kube-proxy startup.
- Updated the post-startup masquerade verification comment.
File summaries
| File | Description |
|---|---|
| pkg/kubernetes/kubeproxy/executor.go | Removes nftables nat flush on startup and updates commentary around masquerade readiness verification. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Note PR image published: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.