Skip to content

Updated README - #264

Merged
porsager merged 7 commits into
porsager:rewritefrom
dilan-dio4:rewrite
Feb 6, 2022
Merged

Updated README#264
porsager merged 7 commits into
porsager:rewritefrom
dilan-dio4:rewrite

Conversation

@dilan-dio4

Copy link
Copy Markdown
Contributor

No description provided.

@dilan-dio4

Copy link
Copy Markdown
Contributor Author

@porsager Here's where I'm at with restructuring some of the README. Let me know your thoughts.

@porsager

porsager commented Feb 6, 2022

Copy link
Copy Markdown
Owner

👏 I love it 😊

cursor now also returns an async iterable if called without a callback function.

I'll comment on the rest in line.

@porsager porsager left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's as far as i got on mobile, I have some more input, but will have to wait until I'm at my computer. 😊

Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
@porsager

porsager commented Feb 6, 2022

Copy link
Copy Markdown
Owner

Ok, going a bit more thoroughly through it here is a list of some more things missing

  • const stream = await sql`copy x from stdin`.writable() and const stream = await sql`copy x to stdout`.readable() is missing.

  • Would be great with a description of the default max_lifetime setting which is a random interval for each connect between 45 and 90 minutes. This seemed to me like the best tradeoff between gaining the benefits of prepared statements, but still staying good friends with the OOM killer on linux. The rand9om interval was set to avoid connections reconnecting in bulk at the exact same time.

  • Large objects usage documentation is not a must for v3 release, but would be nice.

  • A description of the fact that queries are not executed until awaited or .execute() is called. This is necessary to support the usage of sql`` for fragments

  • A mention of Deno support perhaps

@dilan-dio4

Copy link
Copy Markdown
Contributor Author

Changes made. I'll leave stream and Deno to you since I'm not too familiar in those spaces.

@porsager

porsager commented Feb 6, 2022

Copy link
Copy Markdown
Owner

Perfect, I think the rest should be manageable for me one of the coming days.

Do you have more changes, or is merging fine now?

@dilan-dio4

Copy link
Copy Markdown
Contributor Author

Merging is good for now. If I have some more ideas over the next few days I'll add them as well.

@porsager

porsager commented Feb 6, 2022

Copy link
Copy Markdown
Owner

Awesome! Thanks again :)

@porsager
porsager merged commit 81c5df6 into porsager:rewrite Feb 6, 2022
@dilan-dio4

Copy link
Copy Markdown
Contributor Author

Of course! Do we have an ETA for v3 release?

@porsager

porsager commented Feb 6, 2022

Copy link
Copy Markdown
Owner

I don't have any outstanding issues now, so once I've added the rest to the docs we're good to go. During the coming week seems possible.

@dilan-dio4

Copy link
Copy Markdown
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants