Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.

Get-PnPTenantTemplate: Fixing Configuration parameter not being optional and throwing exception - #2873

Merged
erwinvanhunen merged 3 commits into
pnp:devfrom
heinrich-ulbricht:dev-fix-configuration-param-not-optional
Oct 5, 2020
Merged

Get-PnPTenantTemplate: Fixing Configuration parameter not being optional and throwing exception#2873
erwinvanhunen merged 3 commits into
pnp:devfrom
heinrich-ulbricht:dev-fix-configuration-param-not-optional

Conversation

@heinrich-ulbricht

@heinrich-ulbricht heinrich-ulbricht commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes at least some of the "Object reference not set to an instance of the object" errors in #2587 (but not the original 403 error).

What is in this Pull Request ?

Fixing Configuration parameter not being optional by inititializing it with reasonable default value that is not just empty, but contains the given SiteUrl. This fixes the surprising and confusing exception one gets when omitting the parameter. See #2587 for samples of that.

@erwinvanhunen

Copy link
Copy Markdown
Member

Thank you!

@erwinvanhunen
erwinvanhunen merged commit 52cc37a into pnp:dev Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants