new(socket_vmnet): github.com/lima-vm/socket_vmnet recipe (vmnet.framework bridge)#13043
Merged
Merged
Conversation
macOS-only network bridge used by Lima, Colima, and standalone QEMU setups to give VMs a real bridged adapter without needing root on the QEMU process. Built from source via upstream's Makefile (the project is a small C codebase that uses Apple's vmnet.framework). ARCH env var maps pkgx convention (x86-64 / aarch64) to the Makefile's expected form (x86_64 / arm64). linux platforms are absent by design — uses Apple's vmnet.framework which has no Linux equivalent. Test: --help on both binaries (full functionality requires root + vmnet.framework setup that CI can't exercise).
3000784 to
5779561
Compare
Upstream Makefile builds `socket_vmnet_client` directly at the source root (cc -o socket_vmnet_client client/main.o), not under client/. Install line had the wrong path → "cannot stat client/socket_vmnet_client".
4 tasks
Contributor
|
since we have i'll got through these (slowly), but some notes: platforms: [darwin/x86-64, darwin/aarch64]
# is the same as
platforms: [darwin]if you're going to use list-scripts (and you should), it's rarely necessary, or good style, to just use a text script inside it: - run: |
cd foo
ls bar
make baz
# is better as
- run:
- ls bar
- make baz
working-directory: foo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes a mainstream package coverage gap (see pkgxdev/pantry overall package coverage discussion). Draft until CI confirms green.
See commit message for design choices.