Skip to content

revert move to upload-artifact@v4 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhheider wants to merge 2 commits into from
Closed

revert move to upload-artifact@v4 #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ee1f69
revert-upload
jhheider Aug 5, 2024
841dbc7
fix ci.actions.yml
jhheider Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/ci.actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@ jobs:
platform:
- os: ubuntu-latest
name: linux
arch: x86-64
# gha finally added arm runners:
# https://github.com/actions/runner-images
- os: macos-latest
name: darwin
arch: aarch64
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -32,7 +36,7 @@ jobs:
- run: test ${{ steps.build.outputs.project }} = stark.com/foo
- run: test ${{ steps.build.outputs.version }} = 2.3.4
- run: test ${{ steps.build.outputs.platform }} = ${{ matrix.platform.name }}
- run: test ${{ steps.build.outputs.arch }} = x86-64
- run: test ${{ steps.build.outputs.arch }} = ${{ matrix.platform.arch }}
- run: test -d ${{ steps.build.outputs.prefix }}
- run: test $BREWKIT_PKGSPEC = ${{ steps.build.outputs.pkgspec }}
- run: test $BREWKIT_PREFIX = ${{ steps.build.outputs.prefix }}
Expand All @@ -44,7 +48,7 @@ jobs:
strategy:
matrix:
platform-key:
- darwin+x86-64
- darwin+aarch64
- null
runs-on: ubuntu-latest
env:
Expand Down Expand Up @@ -91,7 +95,7 @@ jobs:
matrix:
compression: [xz, gz]
platform:
- darwin+x86-64
- darwin+aarch64
- linux+x86-64
env:
PKGX_PANTRY_PATH: ${{github.workspace}}/co
Expand All @@ -115,7 +119,9 @@ jobs:
file: ${{ steps.dl.outputs.filename }}
compression: ${{matrix.compression}}

- uses: actions/upload-artifact@v4
# v4 is buggy on apple
# https://github.com/actions/upload-artifact/issues/527
- uses: actions/upload-artifact@v3
with:
path: ${{ steps.bottle.outputs.filename }}
name: ${{ steps.bottle.outputs.name }}
Expand Down
4 changes: 3 additions & 1 deletion download-build-artifact/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ runs:
id: prep
shell: bash

- uses: actions/download-artifact@v4
# upload-artifact@v4 is buggy on apple, and versions must match
# https://github.com/actions/upload-artifact/issues/527
- uses: actions/download-artifact@v3
id: download
with:
name: ${{ steps.prep.outputs.artifact-name }}
Expand Down
4 changes: 3 additions & 1 deletion upload-build-artifact/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ runs:
id: tar
shell: bash

- uses: actions/upload-artifact@v4
# v4 is buggy on apple
# https://github.com/actions/upload-artifact/issues/527
- uses: actions/upload-artifact@v3
with:
path: ${{ steps.tar.outputs.path }}
name: ${{ steps.tar.outputs.name }}
Expand Down