Skip to content

fix(web): align Windows update confirmation copy - #7208

Merged
shivamhwp merged 1 commit into
pingdotgg:mainfrom
StiensWout:t3code/align-windows-update-message
Aug 16, 2026
Merged

fix(web): align Windows update confirmation copy#7208
shivamhwp merged 1 commit into
pingdotgg:mainfrom
StiensWout:t3code/align-windows-update-message

Conversation

@StiensWout

@StiensWout StiensWout commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Windows update confirmations still warned that T3 Code could remain closed for several minutes, even though install times have improved and other desktop platforms already use the shorter shared message.

This removes the stale Windows-only warning and its platform-specific helper branch, so Windows now uses the existing Mac/Linux confirmation copy across all three update entry points. Focused coverage now asserts the shared confirmation text.

Tests: pnpm exec vp test run apps/web/src/components/desktopUpdate.logic.test.ts; pnpm exec vp fmt --check ...; pnpm exec vp lint --report-unused-disable-directives ...; pnpm --filter @t3tools/web typecheck.

Model/harness: GPT-5.6 Luna via the Codex harness in T3 Code.


Note

Low Risk
Copy-only change to desktop update confirmation dialogs with no auth, data, or updater behavior changes.

Overview
Removes the Windows-only extra text in the desktop update install confirmation dialog (long silent-install warning) so all platforms use the same short message about restarting and interrupting tasks.

getDesktopUpdateInstallConfirmationMessage no longer takes a platform argument or branches on Windows; LegacySidebar, SettingsPanels, and SidebarUpdatePill call it with update state only. Tests now assert one shared confirmation string instead of separate Windows vs Mac expectations.

Reviewed by Cursor Bugbot for commit 6120bd1. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove Windows-specific copy from desktop update confirmation dialog

The getDesktopUpdateInstallConfirmationMessage function previously appended a Windows-specific silent installation warning based on navigator.platform. It now returns a single, platform-agnostic confirmation message on all platforms. Callers in LegacySidebar.tsx, SidebarUpdatePill.tsx, and SettingsPanels.tsx no longer pass a platform argument.

Macroscope summarized 6120bd1.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 588aa0f2-ab62-4861-b39c-6481aa2b75e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 16, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 6120bd1

This PR removes Windows-specific copy from the update confirmation dialog, simplifying to consistent messaging across all platforms. The changes are limited to UI text and test updates with no runtime behavior impact.

You can customize Macroscope's approvability policy. Learn more.

@shivamhwp
shivamhwp merged commit bab4b6f into pingdotgg:main Aug 16, 2026
18 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 16, 2026
## What's Changed
* fix(mobile): keep sheet actions below status bar by @NitayRabi in pingdotgg/t3code#6635
* fix(web): align Windows update confirmation copy by @StiensWout in pingdotgg/t3code#7208

## New Contributors
* @NitayRabi made their first contribution in pingdotgg/t3code#6635

**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260816.1109...v0.0.34-nightly.20260816.1110

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260816.1110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants