feat(pull-requests): show label descriptions on hover - #6576
feat(pull-requests): show label descriptions on hover#6576RakshithBhat03 wants to merge 5 commits into
Conversation
Co-authored-by: GPT-5.6 <codex@openai.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 5b2dcbc Minor UI enhancement that adds tooltip descriptions to pull request labels on hover. The changes are additive, backward compatible, follow existing tooltip patterns in the codebase, and include comprehensive tests. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
One consistency finding on the new label chip: the hover description is built from Popover rather than the shared Tooltip primitive this file already uses for its other hover-only text. Details inline.
Posted via Macroscope — UI Consistency
Co-authored-by: GPT-5.6 <codex@openai.com>
Dismissing prior approval to re-evaluate 5b2dcbc
Pull request labels in the Summary tab show their name and color, but leave the label's GitHub description inaccessible.
Labels with a non-empty description now use the shared hover-and-focus
Tooltipprimitive, including the standard tooltip surface and accessibility wiring. Labels whose description is missing, null, or blank remain ordinary non-interactive chips, and long unbroken descriptions wrap inside the panel.Descriptions are optional in the shared contract so older clients and providers that do not supply them continue to work. GitHub descriptions are retained only for pull request detail responses; list and cross-repository search payloads stay unchanged.
Verification
vp test run packages/contracts/src/pullRequest.test.ts apps/server/src/pullRequest/gitHubPullRequestJson.test.ts— 86 tests passed.vp run --filter @t3tools/contracts --filter t3 --filter @t3tools/web typecheck— passed. Existing Effect suggestions remain in unchanged server files.vp fmt --check packages/contracts/src/pullRequest.ts packages/contracts/src/pullRequest.test.ts apps/server/src/pullRequest/gitHubPullRequestJson.ts apps/server/src/pullRequest/gitHubPullRequestJson.test.ts apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx— passed.vp lint --report-unused-disable-directives packages/contracts/src/pullRequest.ts packages/contracts/src/pullRequest.test.ts apps/server/src/pullRequest/gitHubPullRequestJson.ts apps/server/src/pullRequest/gitHubPullRequestJson.test.ts apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx— passed with a pre-existingreact(no-array-index-key)warning inPullRequestSummaryTab.tsx.vp run --filter @t3tools/web build— production web build passed.Screenshots
Built by GPT-5.6 in T3 Code through the Codex harness.
Note
Low Risk
Backward-compatible optional field and UI-only tooltip behavior; list payloads unchanged and hosts without descriptions keep working.
Overview
Pull request label descriptions are now available on the Summary tab: chips with a non-empty description use a hover/focus tooltip (same pattern as other PR metadata), while labels without a description stay plain chips.
The shared
PullRequestLabeltype gains an optionaldescription(omitted when the host does not send it,nullwhen empty). GitHub decoding normalizes trimmed text and includes descriptions only on detail responses—list and search rows still expose name and color only, so list payloads stay unchanged.Implementation is split across
toLabels(..., includeDescription)on the server, contract/tests for backward compatibility, and aPullRequestLabelChipcomponent in the Summary tab.Reviewed by Cursor Bugbot for commit 3377fd4. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
[!NOTE]
Show label descriptions on hover in pull request summary tab
descriptionfield to thePullRequestLabelschema in pullRequest.ts, which is absent when the host does not report it andnullwhen no description exists.PullRequestLabelChipcomponent in PullRequestSummaryTab.tsx that wraps labels with a tooltip showing the description when one is present.Macroscope summarized 3377fd4.