fix(server): respect Codex default-mode user input - #5990
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f81329. Configure here.
ApprovabilityVerdict: Approved 87bbe6a This PR makes a minor text clarification to AI developer instructions, refining guidance about when the You can customize Macroscope's approvability policy. Learn more. |

What Changed
When Codex enables
default_mode_request_user_input, the tool can now be used normally. When the flag is absent or disabled, Codex does not advertise the tool and existing behavior remains unchanged.Why
T3 Code always told Codex that
request_user_inputwas unavailable in Default mode. That instruction conflicted with Codex’sdefault_mode_request_user_inputfeature flag when users explicitly enabled it.Fixes #5282
UI Changes
No UI components changed. This uses the existing structured user-input interface.
Feature enabled:

Feature disabled / no override:

Checklist
Note
Low Risk
Prompt-only change in
CodexDeveloperInstructions.ts; no runtime logic, auth, or data paths.Overview
Codex Default mode developer instructions no longer claim
request_user_inputis always unavailable. They now tell the model to use that tool only when it appears in the turn’s tool list, matching when T3 Code exposes it (e.g. with Codex’sdefault_mode_request_user_inputflag).When a question is still required, the guidance is updated to prefer
request_user_inputif listed, otherwise a concise plain-text question—instead of always directing plain-text only.Reviewed by Cursor Bugbot for commit 6f0acd9. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix
request_user_inputtool usage instructions for Codex default modeUpdates the developer instructions in CodexDeveloperInstructions.ts to correctly handle
request_user_inputavailability in Default mode. Previously, the instructions stated the tool was unavailable in Default mode; now they direct the model to use it only when it appears in the available tools list for the turn, and to fall back to a plain-text question otherwise.Macroscope summarized 6f0acd9.