Skip to content

fix(mobile): keep new thread controls above Android keyboard - #5979

Closed
none23 wants to merge 13 commits into
pingdotgg:mainfrom
none23:test/mobile-new-thread-keyboard-controls
Closed

fix(mobile): keep new thread controls above Android keyboard#5979
none23 wants to merge 13 commits into
pingdotgg:mainfrom
none23:test/mobile-new-thread-keyboard-controls

Conversation

@none23

@none23 none23 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What Changed

Use KeyboardStickyView for the Android New Thread layout so the model selector and composer controls follow the keyboard. The existing iOS layout remains unchanged.

Why

On Android, opening the keyboard could leave the New Thread controls behind it, preventing users from selecting a model or accessing composer actions.

Fixes #5615.

UI Changes

Screnshots

Before After
t3-new-thread-before-final t3-new-thread-after-final

Videos

Before
t3-new-thread-keyboard-before-trimmed.mp4
After
t3-new-thread-keyboard-after-trimmed.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Small, Android-only layout change in one screen using an established keyboard pattern elsewhere in the app.

Overview
On Android, the New Thread draft screen no longer wraps the composer in KeyboardAvoidingView. The floating composer (model selector, toolbar, start button) sits in KeyboardStickyView from react-native-keyboard-controller, with enabled={isKeyboardVisible}, so it tracks the IME instead of sitting under the keyboard.

The layout is a flex spacer above the sticky footer, matching the thread composer pattern. iOS still uses KeyboardAvoidingView unchanged.

Fixes #5615.

Reviewed by Cursor Bugbot for commit a5d006a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix new thread controls positioning above Android keyboard in NewTaskDraftScreen

Replaces KeyboardAvoidingView with KeyboardStickyView (from react-native-keyboard-controller) for the Android code path in NewTaskDraftScreen.tsx. The view is enabled only when the keyboard is visible. The iOS path continues to use KeyboardAvoidingView unchanged.

Macroscope summarized a5d006a.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e87b0e0b-daca-4bcf-85d4-020ae1f2505b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 10, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 10, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved decc6ca

Straightforward mobile UI fix switching keyboard handling components from the same library to keep controls above the Android keyboard. Limited scope, clear intent, low risk.

You can customize Macroscope's approvability policy. Learn more.

none23 and others added 9 commits August 10, 2026 12:45
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge force-pushed the test/mobile-new-thread-keyboard-controls branch from ce3aa90 to 80aa8ac Compare August 10, 2026 10:52
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 10, 2026 10:53

Dismissing prior approval to re-evaluate 80aa8ac

Comment thread apps/mobile/src/features/threads/NewTaskDraftScreen.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 30bdc24. Configure here.

Comment thread apps/mobile/src/features/threads/NewTaskDraftScreen.tsx
@none23

none23 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #5986

@none23 none23 closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Android keyboard hides the New Thread model selector and composer controls

2 participants