fix(mobile): keep new thread controls above Android keyboard - #5979
fix(mobile): keep new thread controls above Android keyboard#5979none23 wants to merge 13 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved decc6ca Straightforward mobile UI fix switching keyboard handling components from the same library to keep controls above the Android keyboard. Limited scope, clear intent, low risk. You can customize Macroscope's approvability policy. Learn more. |
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
ce3aa90 to
80aa8ac
Compare
Dismissing prior approval to re-evaluate 80aa8ac
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 30bdc24. Configure here.
|
Superseded by #5986 |

What Changed
Use
KeyboardStickyViewfor the Android New Thread layout so the model selector and composer controls follow the keyboard. The existing iOS layout remains unchanged.Why
On Android, opening the keyboard could leave the New Thread controls behind it, preventing users from selecting a model or accessing composer actions.
Fixes #5615.
UI Changes
Screnshots
Videos
Before
t3-new-thread-keyboard-before-trimmed.mp4
After
t3-new-thread-keyboard-after-trimmed.mp4
Checklist
Note
Low Risk
Small, Android-only layout change in one screen using an established keyboard pattern elsewhere in the app.
Overview
On Android, the New Thread draft screen no longer wraps the composer in
KeyboardAvoidingView. The floating composer (model selector, toolbar, start button) sits inKeyboardStickyViewfromreact-native-keyboard-controller, withenabled={isKeyboardVisible}, so it tracks the IME instead of sitting under the keyboard.The layout is a flex spacer above the sticky footer, matching the thread composer pattern. iOS still uses
KeyboardAvoidingViewunchanged.Fixes #5615.
Reviewed by Cursor Bugbot for commit a5d006a. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix new thread controls positioning above Android keyboard in
NewTaskDraftScreenReplaces
KeyboardAvoidingViewwithKeyboardStickyView(fromreact-native-keyboard-controller) for the Android code path in NewTaskDraftScreen.tsx. The view is enabled only when the keyboard is visible. The iOS path continues to useKeyboardAvoidingViewunchanged.Macroscope summarized a5d006a.