Skip to content

fix(mobile): handle long multi-select user input forms - #5118

Open
thuongtin wants to merge 5 commits into
pingdotgg:mainfrom
thuongtin:fix/mobile-pending-user-input
Open

fix(mobile): handle long multi-select user input forms#5118
thuongtin wants to merge 5 commits into
pingdotgg:mainfrom
thuongtin:fix/mobile-pending-user-input

Conversation

@thuongtin

@thuongtin thuongtin commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What Changed

Long pending user input forms now stay within the mobile viewport and scroll their questions independently, keeping the card header and submit action reachable. Multi-select questions retain every selected option and submit an array, while single-select answers remain scalar.

Why

The mobile client rendered every question inside a non-scrollable sticky card. Forms with several questions overflowed above the screen, and swiping could not reach the clipped content. The same flow reduced multiSelect questions to one option, so users could not provide the answer shape requested by the provider.

UI Changes

Before: the card exceeds the viewport and its beginning is clipped.

Pending user input before

After: the card is bounded, with a scrollable question area and fixed submit action.

Pending user input after

Short scroll interaction video

Validation

  • vp lint passed for all five changed files.
  • vp test run apps/mobile/src/lib/threadActivity.test.ts passed 12 tests.
  • pnpm --filter @t3tools/mobile typecheck passed.
  • A self-contained preview Release APK was exercised on a Pixel 10 Pro XL: the form scrolled through all questions, two multi-select options remained selected together, and the app stayed connected for 35 seconds without a fatal exception or connection-failure loop.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-5. Harness: Codex.


Note

Low Risk
Scoped mobile thread UI and answer-shaping logic with unit tests; no auth or server changes. Minor keyboard-sticky behavior change when the keyboard is hidden.

Overview
Long pending user-input forms on mobile no longer clip off-screen: PendingUserInputCard gets a computed maxHeight, wraps questions in a ScrollView, and keeps the header and Submit action fixed while the question list scrolls.

derivePendingUserInputMaxHeight sizes that card from window height, keyboard, nav header, and composer overlap (with min/max caps). ThreadDetailScreen wires keyboard/window/header state into it and only enables KeyboardStickyView while the keyboard is visible.

Draft/answer handling now supports multiSelect: drafts track selectedOptionLabels, togglePendingUserInputOptionSelection toggles chips vs replaces for single-select, buildPendingUserInputAnswers emits string arrays for multi-select, and option selection passes the full UserInputQuestion through the screen and request hooks.

Reviewed by Cursor Bugbot for commit 85c75ac. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add multi-select support and scrollable layout to pending user input forms on mobile

  • Replaces single-select option logic with togglePendingUserInputOptionSelection, allowing multi-select questions to accumulate or remove selected options; single-select continues to work as before.
  • Adds isPendingUserInputOptionSelected to accurately reflect chip state, ignoring selections when a custom answer is present; entering a custom answer clears selections and vice versa.
  • Wraps the question list in a ScrollView in PendingUserInputCard and computes a responsive max height via derivePendingUserInputMaxHeight, accounting for keyboard height, navigation header, and composer overlap.
  • KeyboardStickyView is now only enabled while the keyboard is visible.
  • buildPendingUserInputAnswers return type is broadened to allow ReadonlyArray<string> for multi-select questions instead of only strings.

Macroscope summarized 85c75ac.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 14de0cbc-8520-4463-a674-8b8c12f3df36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 31, 2026
Comment thread apps/mobile/src/lib/threadActivity.ts
@macroscopeapp

macroscopeapp Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces new multi-select functionality for user input forms (changing from single-select to multi-select behavior) and adds scrolling with keyboard-aware height calculations. While well-tested and self-contained, new user-facing capabilities warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@dtown123

dtown123 commented Aug 1, 2026

Copy link
Copy Markdown

I pulled it down and tested it in Simulator. Some comments:

  • Please consider rendering the option.description as it's quite helpful in the decision process (as found in ComposerPendingUserInputPanel.tsx:192-193).
  • "Type custom answer" is locked in size, which makes long answers difficult to read especially if there's new lines.
  • You can still type in the main prompt box, which is repurposed as the "custom answer" field in Desktop/web during questioning.

While this PR does directly fix the reported bug, it still doesn't match the experience found in other T3 platforms, where each question is asked separately with previous/next buttons, and the prompt input is hidden in favor of a larger "custom answer" field. This is good to stop the bleeding, but I hope full functionality isn't forgotten in the process.

thuongtin and others added 4 commits August 10, 2026 12:56
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge force-pushed the fix/mobile-pending-user-input branch from 78f09ca to 2510bf7 Compare August 10, 2026 10:57

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2510bf7. Configure here.

Comment thread apps/mobile/src/features/threads/pendingUserInputLayout.ts Outdated
Comment thread apps/mobile/src/features/threads/PendingUserInputCard.tsx Outdated
Co-authored-by: codex <codex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants