fix(mobile): handle long multi-select user input forms - #5118
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR introduces new multi-select functionality for user input forms (changing from single-select to multi-select behavior) and adds scrolling with keyboard-aware height calculations. While well-tested and self-contained, new user-facing capabilities warrant human review. You can customize Macroscope's approvability policy. Learn more. |
|
I pulled it down and tested it in Simulator. Some comments:
While this PR does directly fix the reported bug, it still doesn't match the experience found in other T3 platforms, where each question is asked separately with previous/next buttons, and the prompt input is hidden in favor of a larger "custom answer" field. This is good to stop the bleeding, but I hope full functionality isn't forgotten in the process. |
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
78f09ca to
2510bf7
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2510bf7. Configure here.
Co-authored-by: codex <codex@users.noreply.github.com>

What Changed
Long pending user input forms now stay within the mobile viewport and scroll their questions independently, keeping the card header and submit action reachable. Multi-select questions retain every selected option and submit an array, while single-select answers remain scalar.
Why
The mobile client rendered every question inside a non-scrollable sticky card. Forms with several questions overflowed above the screen, and swiping could not reach the clipped content. The same flow reduced
multiSelectquestions to one option, so users could not provide the answer shape requested by the provider.UI Changes
Before: the card exceeds the viewport and its beginning is clipped.
After: the card is bounded, with a scrollable question area and fixed submit action.
Short scroll interaction video
Validation
vp lintpassed for all five changed files.vp test run apps/mobile/src/lib/threadActivity.test.tspassed 12 tests.pnpm --filter @t3tools/mobile typecheckpassed.Checklist
Model: GPT-5. Harness: Codex.
Note
Low Risk
Scoped mobile thread UI and answer-shaping logic with unit tests; no auth or server changes. Minor keyboard-sticky behavior change when the keyboard is hidden.
Overview
Long pending user-input forms on mobile no longer clip off-screen:
PendingUserInputCardgets a computedmaxHeight, wraps questions in aScrollView, and keeps the header and Submit action fixed while the question list scrolls.derivePendingUserInputMaxHeightsizes that card from window height, keyboard, nav header, and composer overlap (with min/max caps).ThreadDetailScreenwires keyboard/window/header state into it and only enablesKeyboardStickyViewwhile the keyboard is visible.Draft/answer handling now supports
multiSelect: drafts trackselectedOptionLabels,togglePendingUserInputOptionSelectiontoggles chips vs replaces for single-select,buildPendingUserInputAnswersemits string arrays for multi-select, and option selection passes the fullUserInputQuestionthrough the screen and request hooks.Reviewed by Cursor Bugbot for commit 85c75ac. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add multi-select support and scrollable layout to pending user input forms on mobile
togglePendingUserInputOptionSelection, allowing multi-select questions to accumulate or remove selected options; single-select continues to work as before.isPendingUserInputOptionSelectedto accurately reflect chip state, ignoring selections when a custom answer is present; entering a custom answer clears selections and vice versa.ScrollViewinPendingUserInputCardand computes a responsive max height viaderivePendingUserInputMaxHeight, accounting for keyboard height, navigation header, and composer overlap.KeyboardStickyViewis now only enabled while the keyboard is visible.buildPendingUserInputAnswersreturn type is broadened to allowReadonlyArray<string>for multi-select questions instead of only strings.Macroscope summarized 85c75ac.