Skip to content

i18n(ja): add missing object-marker particle (wo) before code-span transitive verbs#23272

Draft
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-missing-wo-particle
Draft

i18n(ja): add missing object-marker particle (wo) before code-span transitive verbs#23272
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-missing-wo-particle

Conversation

@yahonda

@yahonda yahonda commented Jul 15, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

This PR adds the missing (object marker) particle before code-span verbs in the Japanese documentation. Machine-translated text frequently dropped between a code span (command flag, identifier, SQL keyword, etc.) and the following transitive verb.

Example: `--force`使用すると`--force`を使用すると

Scope — only unambiguous transitive verbs where the code span is the direct object:

  • 使用 (use), 実行 (execute), 削除 (delete), 取得 (get), 確認 (check), 指定 (specify)
  • followed by an active conjugation (して / すると / する / します / した / しない / できる / できない)

Excluded — to avoid introducing incorrect particles:

  • Passive され forms (which take , not )
  • Compound nouns such as 実行中 / 使用時 (which need no )
  • 設定 / 変更 / 追加 (context-dependent / / , e.g. "set to off" = offに設定)

912 insertions across 397 files. All changes are 1-for-1 line replacements (particle insertion only) — no content changes. No double- introduced (verified).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A (Japanese-only fluency fix)
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. labels Jul 15, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 15, 2026
@yahonda yahonda changed the title i18n(ja): add missing を particle before code-span verbs (使用/実行/削除/取得/確認/指定) i18n(ja): add missing object-marker particle before code-span verbs (use/execute/delete/get/check/specify) Jul 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive proofreading of the Japanese documentation, primarily focusing on correcting particles (such as adding "を" after backticked command, function, or parameter names) and refining verb forms to improve natural logical flow and readability. A review comment was provided pointing out a translation issue in sql-tuning-best-practice.md where the operator list and pushdown description were unnatural compared to the English original; this comment has been kept as it identifies a valid translation improvement opportunity.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sql-tuning-best-practice.md
@yahonda yahonda force-pushed the fix-ja-missing-wo-particle branch from 806fef8 to 3fce32d Compare July 15, 2026 05:13
@yahonda yahonda changed the title i18n(ja): add missing object-marker particle before code-span verbs (use/execute/delete/get/check/specify) i18n(ja): add missing object-marker particle (wo) before code-span transitive verbs Jul 15, 2026
@yahonda yahonda marked this pull request as ready for review July 15, 2026 05:57
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 15, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-07-15 15:17:43.224465574 +0000 UTC m=+813249.260560650: ☑️ agreed by qiancai.

@yahonda yahonda marked this pull request as draft July 16, 2026 00:19
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2026
@yahonda yahonda force-pushed the fix-ja-missing-wo-particle branch from 3fce32d to 37ca169 Compare July 16, 2026 00:38
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 16, 2026
…nsitive verbs

Verbs: 使用/実行/削除/取得/確認/指定/保存/作成/更新/生成/定義/出力/表示/計算/記録/参照 (followed by an active conjugation). Ambiguous verbs (設定/変更/追加/変換/適用: を/に/から) and passive され are excluded.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yahonda yahonda force-pushed the fix-ja-missing-wo-particle branch from 37ca169 to 56a3582 Compare July 16, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants