Add setSpecifyOnly() on SpecifiedTypes to replace FAUX function call workarounds

src/Analyser/SpecifiedTypes.php

@@ -58,6 +58,15 @@ public function setAlwaysOverwriteTypes(): self
 	}
 
 	/**
+	 * When set, ImpossibleCheckTypeHelper evaluates rootExpr in scope
+	 * instead of analysing sureTypes/sureNotTypes.
+	 *
+	 * If rootExpr === the check node itself, isSpecified() bails out
+	 * immediately and ImpossibleCheckTypeHelper returns null.
+	 * This is used when sureTypes are a side effect of the check
+	 * (e.g. str_contains narrowing haystack to non-empty-string)
+	 * rather than the determining condition.
+	 *
 	 * @api
 	 */
 	public function setRootExpr(?Expr $rootExpr): self

src/Type/Php/ArrayKeyExistsFunctionTypeSpecifyingExtension.php

@@ -3,10 +3,7 @@
 namespace PHPStan\Type\Php;
 
 use PhpParser\Node\Expr\ArrayDimFetch;
-use PhpParser\Node\Expr\BinaryOp\Identical;
-use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
-use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
 use PHPStan\Analyser\SpecifiedTypes;
 use PHPStan\Analyser\TypeSpecifier;
@@ -115,7 +112,7 @@ public function specifyTypes(
 					$arrayType->getIterableValueType(),
 					$context,
 					$scope,
-				))->setRootExpr(new Identical($arrayDimFetch, new ConstFetch(new Name('__PHPSTAN_FAUX_CONSTANT'))));
+				))->setRootExpr($node);
 			}
 
 			return new SpecifiedTypes();

src/Type/Php/StrContainingTypeSpecifyingExtension.php

@@ -2,12 +2,7 @@
 
 namespace PHPStan\Type\Php;
 
-use PhpParser\Node\Arg;
-use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
-use PhpParser\Node\Expr\BinaryOp\NotIdentical;
 use PhpParser\Node\Expr\FuncCall;
-use PhpParser\Node\Name;
-use PhpParser\Node\Scalar\String_;
 use PHPStan\Analyser\Scope;
 use PHPStan\Analyser\SpecifiedTypes;
 use PHPStan\Analyser\TypeSpecifier;
@@ -89,15 +84,7 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 					new IntersectionType($accessories),
 					$context,
 					$scope,
-				)->setRootExpr(new BooleanAnd(
-					new NotIdentical(
-						$args[$needleArg]->value,
-						new String_(''),
-					),
-					new FuncCall(new Name('FAUX_FUNCTION'), [
-						new Arg($args[$needleArg]->value),
-					]),
-				));
+				)->setRootExpr($node);
 			}
 		}
 

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php

@@ -507,6 +507,12 @@ public function testNonEmptySpecifiedString(): void
 		$this->analyse([__DIR__ . '/data/non-empty-string-impossible-type.php'], []);
 	}
 
+	public function testBug14705(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-14705.php'], []);
+	}
+
 	public function testBug2755(): void
 	{
 		$this->treatPhpDocTypesAsCertain = true;

tests/PHPStan/Rules/Comparison/data/bug-14705.php

@@ -0,0 +1,110 @@
+<?php
+
+namespace Bug14705;
+
+class Foo
+{
+
+	/**
+	 * str_contains with non-empty-string haystack should not report always-true.
+	 *
+	 * @param non-empty-string $haystack
+	 */
+	public function strContainsNonEmpty(string $haystack, string $needle): void
+	{
+		if (str_contains($haystack, $needle)) {
+
+		}
+	}
+
+	/**
+	 * str_starts_with with non-empty-string haystack should not report always-true.
+	 *
+	 * @param non-empty-string $haystack
+	 */
+	public function strStartsWithNonEmpty(string $haystack, string $needle): void
+	{
+		if (str_starts_with($haystack, $needle)) {
+
+		}
+	}
+
+	/**
+	 * str_ends_with with non-empty-string haystack should not report always-true.
+	 *
+	 * @param non-empty-string $haystack
+	 */
+	public function strEndsWithNonEmpty(string $haystack, string $needle): void
+	{
+		if (str_ends_with($haystack, $needle)) {
+
+		}
+	}
+
+	/**
+	 * strpos with non-empty-string haystack should not report always-true.
+	 *
+	 * @param non-empty-string $haystack
+	 * @param non-empty-string $needle
+	 */
+	public function strposNonEmpty(string $haystack, string $needle): void
+	{
+		if (strpos($haystack, $needle) !== false) {
+
+		}
+	}
+
+	/**
+	 * array_key_exists with non-constant key on a non-empty-array should not report always-true.
+	 *
+	 * @param non-empty-array<string, int> $array
+	 */
+	public function arrayKeyExistsNonEmpty(array $array, string $key): void
+	{
+		if (array_key_exists($key, $array)) {
+
+		}
+	}
+
+	/**
+	 * @param non-empty-string $needle
+	 */
+	public function strEndsWithDuplicate(string $haystack, string $needle): void
+	{
+		if (str_ends_with($haystack, $needle)) {
+			if (str_ends_with($haystack, $needle)) { // could be reported as always-true
+
+			}
+		}
+	}
+
+	/**
+	 * @param non-empty-string $needle
+	 */
+	public function strContainsDuplicate(string $haystack, string $needle): void
+	{
+		if (str_contains($haystack, $needle)) {
+			if (str_contains($haystack, $needle)) { // could be reported as always-true
+
+			}
+		}
+	}
+
+	/**
+	 * @phpstan-assert-if-true =non-empty-string $foo
+	 */
+	public function isValid(string $foo): bool
+	{
+		return $foo !== '';
+	}
+
+	public function equalityAssertDuplicate(string $task): void
+	{
+		if ($this->isValid($task)) {
+			if ($this->isValid($task)) { // could be reported as always-true
+
+			}
+		}
+	}
+
+}