Skip to content

Refine module auth#89

Merged
iMattPro merged 5 commits into
phpbb-extensions:mainfrom
iMattPro:Fixins
Nov 11, 2024
Merged

Refine module auth#89
iMattPro merged 5 commits into
phpbb-extensions:mainfrom
iMattPro:Fixins

Conversation

@iMattPro

@iMattPro iMattPro commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

The test fix should eliminate the random test failings

Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro
iMattPro requested a review from rxu November 6, 2024 16:33
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro

iMattPro commented Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

@paul999 What are your thoughts on the proposed changes to the two migration files? In particular, what would happen if we uncommented the erroneous line in the first migration file?

@paul999

paul999 commented Nov 8, 2024

Copy link
Copy Markdown

I would say if you umcomment, the other migration is technically direclty effectivly installed for new installs.
However, to keep in line with not changing migrations, I would say leave it out, as you already need to fix old installs. And for new installs it doesn't matter the if it is directly set correctly, or via the second migration.

@iMattPro

iMattPro commented Nov 8, 2024

Copy link
Copy Markdown
Contributor Author

I would say if you umcomment, the other migration is technically direclty effectivly installed for new installs. However, to keep in line with not changing migrations, I would say leave it out, as you already need to fix old installs. And for new installs it doesn't matter the if it is directly set correctly, or via the second migration.

Okay, I’ll leave it in but commented out. I’m doing this to prevent anyone who might copy this code for themselves from making the same mistake we did with adding modules. We forgot that line of code.

@paul999

paul999 commented Nov 8, 2024

Copy link
Copy Markdown

Yep, sounds good. Please mention it when submitting, so we don't forget we discussed it already.

Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro
iMattPro merged commit 9fe40af into phpbb-extensions:main Nov 11, 2024
@iMattPro
iMattPro deleted the Fixins branch November 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants