Refine module auth#89
Conversation
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
|
@paul999 What are your thoughts on the proposed changes to the two migration files? In particular, what would happen if we uncommented the erroneous line in the first migration file? |
|
I would say if you umcomment, the other migration is technically direclty effectivly installed for new installs. |
Okay, I’ll leave it in but commented out. I’m doing this to prevent anyone who might copy this code for themselves from making the same mistake we did with adding modules. We forgot that line of code. |
|
Yep, sounds good. Please mention it when submitting, so we don't forget we discussed it already. |
Signed-off-by: Matt Friedman <maf675@gmail.com>
The test fix should eliminate the random test failings