Update README.md#83
Merged
Merged
Conversation
Signed-off-by: Matt Friedman <maf675@gmail.com>
iMattPro
force-pushed
the
iMattPro-patch-1
branch
from
October 1, 2024 15:14
cac06ff to
cdf7fbc
Compare
rxu
reviewed
Oct 1, 2024
| 4. **Caveats for Local Testing** | ||
| - Local testing of Push Notifications only works from a `localhost` address or if your local server has a secure SSL certificate. | ||
| - We have seen success on Windows using manually installed PHP, Apache and MySQL. However, for reasons not yet known we do not see success on Mac using MAMP. | ||
| - Depending on your local server's setup, operating system, and browser versions, it is still possible that testing push notifications may not work (for example, in a local environment running on macOS, only Chrome will show notifications while it is open or after it has been launched). |
Contributor
There was a problem hiding this comment.
I'd also add 2 things:
- notifications should be allowed for both browser applications in respective operation system,
- 2nd browser should be open or working in a background (sometimes, because if you close it OS may terminate the background process in some cases) to be able to display notifications.
Contributor
Author
There was a problem hiding this comment.
2nd notification isn't necessary as we're only using 1 account to recieve and another account to trigger. Want to keep it simple and not confusing.
Signed-off-by: Matt Friedman <maf675@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.