Skip to content

Design changes#61

Merged
iMattPro merged 13 commits into
phpbb-extensions:mainfrom
iMattPro:funstuff
Jun 24, 2024
Merged

Design changes#61
iMattPro merged 13 commits into
phpbb-extensions:mainfrom
iMattPro:funstuff

Conversation

@iMattPro

@iMattPro iMattPro commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

Updated toggle
Screenshot 2024-06-18 at 8 19 27 PM

Re-did the UCP
Screenshot 2024-06-17 at 12 03 30 PM

Screenshot 2024-06-18 at 8 19 52 PM

@iMattPro iMattPro added enhancement New feature or request WIP 🚧 labels Jun 17, 2024
@iMattPro
iMattPro force-pushed the funstuff branch 3 times, most recently from 352e659 to c03a635 Compare June 17, 2024 22:51
iMattPro added 3 commits June 17, 2024 15:51
Signed-off-by: Matt Friedman <maf675@gmail.com>

Language updates

Signed-off-by: Matt Friedman <maf675@gmail.com>

Update tests

Signed-off-by: Matt Friedman <maf675@gmail.com>

Lang fixes

Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>

Shrink responsive breakpoint

Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
iMattPro added 5 commits June 17, 2024 22:12
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro iMattPro removed the WIP 🚧 label Jun 20, 2024
iMattPro added 2 commits June 20, 2024 19:59
Signed-off-by: Matt Friedman <maf675@gmail.com>

# Conflicts:
#	language/ru/webpushnotifications_module_ucp.php
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro
iMattPro requested a review from rxu June 23, 2024 01:34
Comment thread acp/wpn_acp_module.php Outdated
'U_ACTION' => $this->u_action,
]);

if (!$this->request->server('HTTPS', false))

@rxu rxu Jun 23, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it shows error on localhost. Probably it's worth adding a check for !($this->request->server('SERVER_NAME', '') == 'localhost') or some kind of that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah

Signed-off-by: Matt Friedman <maf675@gmail.com>

@rxu rxu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall fix ru translation later.

@iMattPro
iMattPro merged commit 3eff72d into phpbb-extensions:main Jun 24, 2024
@iMattPro
iMattPro deleted the funstuff branch June 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants