ext/gmp: Emit deprecation for precision-losing float RHS in ** / << / >>#21935
Open
LamentXU123 wants to merge 4 commits intophp:PHP-8.4from
Open
ext/gmp: Emit deprecation for precision-losing float RHS in ** / << / >>#21935LamentXU123 wants to merge 4 commits intophp:PHP-8.4from
LamentXU123 wants to merge 4 commits intophp:PHP-8.4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this TODO message in the code base
Ah, so using zend_try_long() here will cause some precision loss and should be fixed after 8.3. So I created this PR targeting 8.4. I don't sure if this worth a NEWS entry. Also may need to merge this PR to other branches since I don't have access :)
cc @Girgias