Syntax highlighting modified lines#19834
Open
FedeLoch wants to merge 27 commits into
Open
Conversation
* making tab closable * fix * new tba * better tab * fix bug * fix another bug * improving tab diff view * improve size * width * diff * fix * feedback view * improve feedback * fixing condition * fix * fix bug
* improving ux * fix error * fix bug * opening with deleted lines too * ux improvement * showing the whole feedbakc * fixing the height * fixing focus * fix error * centering the focus on the line
Member
|
Great! |
Contributor
Author
Do you mean to open a quick read-only editor with a definition?. The current read-only editor is showing the diff between the current text and the source of the same method ( class package ) that is saved in the repository that contains it. |
Collaborator
|
Really nice, good work
Pablo Tesone.
***@***.***
…On Sat, Jun 27, 2026, 16:58 Federico Lochbaum ***@***.***> wrote:
*FedeLoch* left a comment (pharo-project/pharo#19834)
<#19834 (comment)>
Great! Now do you think that with the same mechanism we could see the
method definition of a nessage send (to a monomoprhic or self send)?
Do you mean to open a quick read-only editor with a definition?.
The current read-only editor is showing the diff between the current text
and the source of the same method ( class package ) that is saved in the
repository that contains it.
—
Reply to this email directly, view it on GitHub
<#19834?email_source=notifications&email_token=AACWY76T6RZMFWEC43FFIN35B7OJHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBRHA2TMMZUGYZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-4818563462>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWY77OOEVT3DJQOO75B2L5B7OJHAVCNFSNUABEKJSXA33TNF2G64TZHM3DIMJSGM2DQMB3JFZXG5LFHM2DONJXHA2TSNJRGKQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AACWY72U7QDFXM2NZERDLMD5B7OJHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBRHA2TMMZUGYZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
and Android
<https://github.com/notifications/mobile/android/AACWY7Y42PZSWOJKN6FRBY35B7OJHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBRHA2TMMZUGYZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
FedeLoch
changed the title
FedeLoch
marked this pull request as ready for review
July 5, 2026 11:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syntax highlighting modified lines [POC]
This pr adds the Diff edition feedback feature for Pharo.
How does it work?
When we modify a line, we observe this feedback:
When we add a new line, we observe:
And when we delete one:
If we click any of them, we will see a read-only editor displaying the diff view, with the selected line highlighted:
UI/UX Experience
Screen.Recording.2026-06-27.at.11.56.38.mov
Notes