Skip to content

feat(tls): load full certificate chain for server acceptor#985

Open
SAY-5 wants to merge 1 commit into
pgdogdev:mainfrom
SAY-5:feat-tls-cert-chain
Open

feat(tls): load full certificate chain for server acceptor#985
SAY-5 wants to merge 1 commit into
pgdogdev:mainfrom
SAY-5:feat-tls-cert-chain

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented May 19, 2026

Fixes #834. build_acceptor read only the first certificate from tls_certificate, so server certs not signed directly by a root CA failed validation. Per the maintainer's note that build_acceptor "could probably be adapted with no additional changes to make TLS work correctly", this reads the whole PEM file with pem_file_iter (mirroring build_client_cert_verifier) and passes the full chain to with_single_cert. Adds a regression test with a two-cert chain fixture.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/net/tls.rs 61.11% 14 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@levkk levkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Would be happy to merge this if you can sign the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLS Certificate Chain support

3 participants