feat(tls): load full certificate chain for server acceptor#985
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
levkk
approved these changes
May 19, 2026
Collaborator
levkk
left a comment
There was a problem hiding this comment.
Awesome! Would be happy to merge this if you can sign the CLA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #834.
build_acceptorread only the first certificate fromtls_certificate, so server certs not signed directly by a root CA failed validation. Per the maintainer's note thatbuild_acceptor"could probably be adapted with no additional changes to make TLS work correctly", this reads the whole PEM file withpem_file_iter(mirroringbuild_client_cert_verifier) and passes the full chain towith_single_cert. Adds a regression test with a two-cert chain fixture.