Improve plrustc lint messages

plrustc/plrustc/src/lints/builtin_macros.rs

@@ -19,7 +19,7 @@ impl PlrustBuiltinMacros {
     fn lint_fs(&self, cx: &LateContext<'_>, sp: Span) {
         cx.lint(
             PLRUST_FILESYSTEM_MACROS,
-            "the `include_str`, `include_bytes`, and `include` macros are forbidden",
+            "the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust",
             |b| b.set_span(sp),
         );
     }

plrustc/plrustc/src/lints/extern_blocks.rs

@@ -14,7 +14,7 @@ impl<'tcx> LateLintPass<'tcx> for NoExternBlockPass {
             // TODO: Do we need to allow ones from macros from pgrx?
             cx.lint(
                 PLRUST_EXTERN_BLOCKS,
-                "`extern` blocks are not allowed",
+                "`extern` blocks are not allowed in PL/Rust",
                 |b| b.set_span(item.span),
             )
         }

plrustc/plrustc/src/lints/lifetime_param_trait.rs

@@ -15,7 +15,7 @@ impl<'tcx> LateLintPass<'tcx> for LifetimeParamTraitPass {
                 if let hir::GenericParamKind::Lifetime { .. } = param.kind {
                     cx.lint(
                         PLRUST_LIFETIME_PARAMETERIZED_TRAITS,
-                        "Trait is parameterize by lifetime.",
+                        "PL/Rust forbids declaring traits with generic lifetime parameters",
                         |b| b.set_span(item.span),
                     )
                 }

plrustc/plrustc/src/lints/print_macros.rs

@@ -27,7 +27,8 @@ impl PlrustPrintMacros {
     fn fire(&self, cx: &LateContext<'_>, span: Span) {
         cx.lint(
             PLRUST_PRINT_MACROS,
-            "the printing macros are forbidden, consider using `log!()` instead",
+            "the printing macros are forbidden in PL/Rust, \
+            consider using `pgrx::log!()` instead",
             |b| b.set_span(span),
         );
     }

plrustc/plrustc/src/lints/static_impls.rs

@@ -16,7 +16,8 @@ impl<'tcx> LateLintPass<'tcx> for PlrustStaticImpls {
         if self.has_static(imp.self_ty) {
             cx.lint(
                 PLRUST_STATIC_IMPLS,
-                "`impl` blocks for types containing `'static` references are not allowed",
+                "`impl` blocks for types containing `'static` references \
+                are not allowed in PL/Rust",
                 |b| b.set_span(imp.self_ty.span),
             )
         }

plrustc/plrustc/src/lints/stdio.rs

@@ -19,7 +19,8 @@ impl<'tcx> LateLintPass<'tcx> for PlrustPrintFunctions {
             if super::utils::does_expr_call_path(cx, expr, path) {
                 cx.lint(
                     PLRUST_STDIO,
-                    "the standard streams are forbidden, consider using `log!()` instead",
+                    "the standard streams are forbidden in PL/Rust, \
+                    consider using `pgrx::log!()` instead",
                     |b| b.set_span(expr.span),
                 );
             }

plrustc/plrustc/src/lints/sus_trait_object.rs

@@ -30,7 +30,7 @@ impl<'tcx> LateLintPass<'tcx> for PlrustSuspiciousTraitObject {
                 if let hir::TyKind::TraitObject(..) = &ty.kind {
                     cx.lint(
                         PLRUST_SUSPICIOUS_TRAIT_OBJECT,
-                        "trait objects in turbofish are forbidden",
+                        "using trait objects in turbofish position is forbidden by PL/Rust",
                         |b| b.set_span(expr.span),
                     );
                 }

plrustc/plrustc/uitests/extern_block.stderr

@@ -1,24 +1,24 @@
-error: `extern` blocks are not allowed
+error: `extern` blocks are not allowed in PL/Rust
   --> $DIR/extern_block.rs:2:1
    |
 LL | extern "C" {}
    | ^^^^^^^^^^^^^
    |
    = note: `-F plrust-extern-blocks` implied by `-F plrust-lints`
 
-error: `extern` blocks are not allowed
+error: `extern` blocks are not allowed in PL/Rust
   --> $DIR/extern_block.rs:3:1
    |
 LL | extern "Rust" {}
    | ^^^^^^^^^^^^^^^^
 
-error: `extern` blocks are not allowed
+error: `extern` blocks are not allowed in PL/Rust
   --> $DIR/extern_block.rs:5:1
    |
 LL | extern {}
    | ^^^^^^^^^
 
-error: `extern` blocks are not allowed
+error: `extern` blocks are not allowed in PL/Rust
   --> $DIR/extern_block.rs:9:9
    |
 LL |         extern "C" {}

plrustc/plrustc/uitests/fs_macros.stderr

@@ -1,78 +1,78 @@
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:3:18
    |
 LL | const _A: &str = include_str!("fs_macros_included_file.txt");
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-F plrust-filesystem-macros` implied by `-F plrust-lints`
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:5:19
    |
 LL | const _B: &[u8] = include_bytes!("fs_macros_included_file.txt");
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:7:18
    |
 LL | const _C: &str = core::include_str!("fs_macros_included_file.txt");
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:8:19
    |
 LL | const _D: &[u8] = core::include_bytes!("fs_macros_included_file.txt");
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:16:18
    |
 LL | const _E: &str = indirect!(include_str);
    |                  ^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:17:19
    |
 LL | const _F: &[u8] = indirect!(include_bytes);
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:31:18
    |
 LL | const _G: &str = in_macro!();
    |                  ^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:32:28
    |
 LL | const _H: &str = in_macro!(include_str!("fs_macros_included_file.txt"));
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:33:29
    |
 LL | const _I: &[u8] = in_macro!(include_bytes!("fs_macros_included_file.txt"));
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:34:19
    |
 LL | const _J: &[u8] = in_macro!(include_bytes, "fs_macros_included_file.txt");
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:37:18
    |
 LL | const _L: &str = sneaky!("fs_macros_included_file.txt");
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:38:18
    |
 LL | const _M: &str = in_macro!(sneaky, "fs_macros_included_file.txt");
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: the `include_str`, `include_bytes`, and `include` macros are forbidden
+error: the `include_str`, `include_bytes`, and `include` macros are forbidden in PL/Rust
   --> $DIR/fs_macros.rs:41:21
    |
 LL |     format!("{:?}", in_macro!())

plrustc/plrustc/uitests/lifetime_trait.stderr

@@ -1,12 +1,12 @@
-error: Trait is parameterize by lifetime.
+error: PL/Rust forbids declaring traits with generic lifetime parameters
   --> $DIR/lifetime_trait.rs:3:1
    |
 LL | trait Foo<'a> {}
    | ^^^^^^^^^^^^^^^^
    |
    = note: `-F plrust-lifetime-parameterized-traits` implied by `-F plrust-lints`
 
-error: Trait is parameterize by lifetime.
+error: PL/Rust forbids declaring traits with generic lifetime parameters
   --> $DIR/lifetime_trait.rs:9:9
    |
 LL |         trait Foobar<'a> {}