Remove unused dead code - #288
Merged
Merged
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 12. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
omer9564
approved these changes
Oct 6, 2025
dshoen619
added a commit
that referenced
this pull request
Jul 5, 2026
CI pytests started failing with: TypeError: ClientResponse.__init__() missing 1 required keyword-only argument: 'stream_writer' aiohttp 3.14 made stream_writer a required kwarg of ClientResponse.__init__, which the latest released aioresponses (0.7.9) does not pass. aiohttp/ aioresponses are unpinned so CI installs the latest, and this surfaced once aiohttp 3.14 shipped -- unrelated to this PR's dependency bumps. We stay on aiohttp 3.14.x on purpose: the June 2026 aiohttp security fixes landed in 3.14 and were not backported to 3.13.x, so pinning aiohttp down to satisfy aioresponses would reintroduce those CVEs into the image. Instead add a test-only conftest shim (mirrors upstream aioresponses PR #288, unreleased) that injects a dummy stream_writer. No-op on aiohttp < 3.14. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dshoen619
added a commit
that referenced
this pull request
Jul 7, 2026
* fix(deps): bump cryptography to 48.0.1 to patch GHSA-537c-gmf6-5ccf (PER-15358) Docker Scout flagged cryptography 46.0.7 (1 High) in the pdp-v2 image. Bump the pin from >=46.0.5,<47 to >=48.0.1,<49; resolves cleanly against the rest of the tree (fastapi 0.125.0, opal 0.9.6). Also documents that the two starlette High CVEs (CVE-2026-54283, CVE-2026-48818; fixed in starlette 1.1.0/1.3.1) are blocked upstream: opal-common/opal-client 0.9.6 (latest) hard-cap starlette<1. The 18 Go CVEs (all Criticals) are fixed in permit-opa#38. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test: fix aioresponses incompatibility with aiohttp 3.14 (PER-15358) CI pytests started failing with: TypeError: ClientResponse.__init__() missing 1 required keyword-only argument: 'stream_writer' aiohttp 3.14 made stream_writer a required kwarg of ClientResponse.__init__, which the latest released aioresponses (0.7.9) does not pass. aiohttp/ aioresponses are unpinned so CI installs the latest, and this surfaced once aiohttp 3.14 shipped -- unrelated to this PR's dependency bumps. We stay on aiohttp 3.14.x on purpose: the June 2026 aiohttp security fixes landed in 3.14 and were not backported to 3.13.x, so pinning aiohttp down to satisfy aioresponses would reintroduce those CVEs into the image. Instead add a test-only conftest shim (mirrors upstream aioresponses PR #288, unreleased) that injects a dummy stream_writer. No-op on aiohttp < 3.14. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci: run pdp-tester via Docker runtime instead of k3d (PER-15358) The pdp-tester job failed at the "Start k3d cluster" step: Downloading k3d@v5.4.6 ... curl: (22) ... error: 404 Failed to install k3d AbsaOSS/k3d-action@v2.4.0 defaults to k3d v5.4.6, whose GitHub release has no checksums.txt; k3d's install.sh now SHA256-verifies the binary against that file, so the download 404s. This is environmental (passed on main in May) and unrelated to this PR. Per the pdp-tester maintainers, switch the job to the tester's new Docker runtime backend (aiodocker), which launches the PDP as a local container with no k3d/Helm/kubectl -- mirroring pdp-tester's own `pdp-tester-docker` CI job. LOCAL_IMAGE pins it to the locally built permitio/pdp-v2:next image (loaded from the build artifact) so nothing is pulled from Docker Hub. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.