Skip to content

Revert "chore: upgrade Chromium from v126 to v143 for asset discovery" #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manoj-Katta merged 1 commit into from
May 18, 2026
Merged

Revert "chore: upgrade Chromium from v126 to v143 for asset discovery" #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/.cache-key
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
; ;
/ \
_____________/_ __ \_____________
Times we have broken CI: 4
Times we have broken CI: 3
Times Windows has broken CI: 99+
19 changes: 4 additions & 15 deletions packages/core/src/browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,6 @@ import install from './install.js';
import Session from './session.js';
import Page from './page.js';

// Chrome features Percy disables for v143 new-headless asset discovery.
const DISABLED_FEATURES = [
'Translate', // suppress translate prompt overlay
'OptimizationGuideModelDownloading', // suppress background model fetches
'IsolateOrigins', // [headless-only] keep cross-origin sub-resources on the page session for CDP capture
'site-per-process', // companion to IsolateOrigins
'HttpsFirstBalancedModeAutoEnable', // allow HTTP customer URLs (CI / local dev / staging)
'LocalNetworkAccessChecks' // allow loopback/RFC1918 sub-resources (Chrome 143 LNA gating)
];

export class Browser extends EventEmitter {
log = logger('core:browser');
sessions = new Map();
Expand All @@ -31,7 +21,8 @@ export class Browser extends EventEmitter {
#lastid = 0;

args = [
`--disable-features=${DISABLED_FEATURES.join(',')}`,
// disable the translate popup and optimization downloads
'--disable-features=Translate,OptimizationGuideModelDownloading',
// disable several subsystems which run network requests in the background
'--disable-background-networking',
// disable task throttling of timer tasks from background pages
Expand Down Expand Up @@ -309,11 +300,9 @@ export class Browser extends EventEmitter {
if (match) cleanup(() => resolve(match[1]));
};

let handleExitClose = () => handleError(
new Error('Browser exited before devtools address')
);
let handleExitClose = () => handleError();
let handleError = error => cleanup(() => reject(new Error(
`Failed to launch browser. ${error.message}\n${stderr}'\n\n`
`Failed to launch browser. ${error?.message ?? ''}\n${stderr}'\n\n`
)));

let cleanup = callback => {
Expand Down
13 changes: 6 additions & 7 deletions packages/core/src/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,13 @@ export function chromium({
});
}

// Chrome 143.0.7499.169 (base position 1536371) — closest per-platform
// revision from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html
// default chromium revisions corresponds to v126.0.6478.184
chromium.revisions = {
linux: '1536366',
win64: '1536376',
win32: '1536377',
darwin: '1536380',
darwinArm: '1536376'
linux: '1300309',
win64: '1300297',
win32: '1300295',
darwin: '1300293',
darwinArm: '1300314'
};

// export the namespace by default
Expand Down
251 changes: 25 additions & 226 deletions packages/core/src/network.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading