Skip to content

chore(migration): dashboard specs to ts#760

Merged
tdelatorre merged 3 commits into
mainfrom
tdelatorre/task/migrate/dashboard
Jul 16, 2026
Merged

chore(migration): dashboard specs to ts#760
tdelatorre merged 3 commits into
mainfrom
tdelatorre/task/migrate/dashboard

Conversation

@tdelatorre

@tdelatorre tdelatorre commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Done Definition Checks

Description

This PR migrates dashboard specs to ts. Including snapshots.

How to test

  • Check the code
  • Update the test case in Qase (Automation Status field or steps changed)
  • It complies with the test conventions
  • There are no missing snapshots
  • The tests run OK

Screenshots 📸

dashboard

@tdelatorre tdelatorre self-assigned this Jul 14, 2026
@tdelatorre
tdelatorre force-pushed the tdelatorre/task/migrate/dashboard branch from 3378633 to bc31512 Compare July 14, 2026 11:05
@tdelatorre
tdelatorre force-pushed the tdelatorre/task/migrate/dashboard branch 2 times, most recently from 2327d3e to 65c33ea Compare July 14, 2026 11:54
@tdelatorre
tdelatorre force-pushed the tdelatorre/task/migrate/dashboard branch from 65c33ea to 696831d Compare July 15, 2026 07:27
@tdelatorre
tdelatorre force-pushed the tdelatorre/task/migrate/dashboard branch from 696831d to 6de8daa Compare July 15, 2026 09:01
@tdelatorre
tdelatorre marked this pull request as ready for review July 15, 2026 09:55
@estefafdez
estefafdez self-requested a review July 15, 2026 09:57
@tdelatorre
tdelatorre force-pushed the tdelatorre/task/migrate/dashboard branch from 6de8daa to 7603a8d Compare July 16, 2026 03:53
@estefafdez
estefafdez requested a review from Copilot July 16, 2026 05:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates several dashboard-related Playwright specs from JavaScript to TypeScript and updates/introduces corresponding snapshot assets, aligning these tests with the repository’s TS-based test structure and utilities.

Changes:

  • Converted multiple dashboard/team specs from .spec.js to .spec.ts and updated imports to use path aliases.
  • Refactored some tests to use mainTest.step(...) blocks and added small TS helper types/guards (e.g., requireMessage).
  • Added/updated screenshot snapshots for TS specs.

Reviewed changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/dashboard/user-menu.spec.ts TS version of the user-menu link/navigation assertions.
tests/dashboard/user-menu.spec.js Removed legacy JS spec after TS migration.
tests/dashboard/teams/teams-viewer-role.spec.ts TS migration of viewer role permissions/role-change scenarios; uses screenshots.
tests/dashboard/teams/teams-viewer-role.spec.js Removed legacy JS spec after TS migration.
tests/dashboard/teams/teams-viewer-role.spec.ts-snapshots/right-sidebar-image.png Added snapshot used by the TS viewer-role spec.
tests/dashboard/teams/teams-request-access.spec.ts Migrated to TS with typed helpers/guards and some structural cleanup.
tests/dashboard/teams/teams-rename.spec.ts TS migration of team rename scenarios.
tests/dashboard/teams/teams-rename.spec.js Removed legacy JS spec after TS migration.
tests/dashboard/teams/teams-permissions.spec.ts TS import/style updates for teams permissions tests.
tests/dashboard/teams/teams-members.spec.ts TS migration for member role-change/leave scenarios (contains a blocking fixture-hook issue).
tests/dashboard/teams/teams-members.spec.js Removed legacy JS spec after TS migration.
tests/dashboard/teams/teams-management.spec.ts TS migration of basic team management (create/switch/delete).
tests/dashboard/teams/teams-management.spec.js Removed legacy JS spec after TS migration.
tests/dashboard/teams/teams-leave-team.spec.ts TS migration of leave-team tests (with an overly complex type).
tests/dashboard/teams/settings/teams-settings.spec.ts TS migration of team settings tests using screenshot assertions.
tests/dashboard/teams/settings/teams-settings.spec.js Removed legacy JS spec after TS migration.
tests/dashboard/teams/settings/teams-settings.spec.ts-snapshots/team-profile-image.png Added snapshot used by the TS team-settings spec.
tests/dashboard/dashboard-fonts.spec.ts TS migration of dashboard fonts tests (upload/search/edit/delete flows).
tests/dashboard/dashboard-fonts.spec.js Removed legacy JS spec after TS migration.
Comments suppressed due to low confidence (2)

tests/dashboard/teams/teams-leave-team.spec.ts:32

  • The page parameter type for setupInvitedUser is an overly complex conditional type that always resolves to Page and makes the helper harder to read/maintain. It can be simplified to page: Page without changing behavior.
    tests/dashboard/teams/teams-permissions.spec.ts:8
  • This file imports LayersPanelPage with an explicit .js extension, but the rest of the TS test suite consistently imports it without the extension. Keeping the import style consistent avoids resolver edge-cases with path aliases and makes refactors easier.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/dashboard/teams/teams-members.spec.ts

@estefafdez estefafdez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tdelatorre
tdelatorre merged commit 3fb4fd3 into main Jul 16, 2026
1 check passed
@tdelatorre
tdelatorre deleted the tdelatorre/task/migrate/dashboard branch July 16, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants