chore(migration): dashboard specs to ts#760
Merged
Merged
Conversation
tdelatorre
force-pushed
the
tdelatorre/task/migrate/dashboard
branch
from
July 14, 2026 11:05
3378633 to
bc31512
Compare
tdelatorre
force-pushed
the
tdelatorre/task/migrate/dashboard
branch
2 times, most recently
from
July 14, 2026 11:54
2327d3e to
65c33ea
Compare
tdelatorre
force-pushed
the
tdelatorre/task/migrate/dashboard
branch
from
July 15, 2026 07:27
65c33ea to
696831d
Compare
tdelatorre
force-pushed
the
tdelatorre/task/migrate/dashboard
branch
from
July 15, 2026 09:01
696831d to
6de8daa
Compare
tdelatorre
marked this pull request as ready for review
July 15, 2026 09:55
estefafdez
self-requested a review
July 15, 2026 09:57
tdelatorre
force-pushed
the
tdelatorre/task/migrate/dashboard
branch
from
July 16, 2026 03:53
6de8daa to
7603a8d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates several dashboard-related Playwright specs from JavaScript to TypeScript and updates/introduces corresponding snapshot assets, aligning these tests with the repository’s TS-based test structure and utilities.
Changes:
- Converted multiple dashboard/team specs from
.spec.jsto.spec.tsand updated imports to use path aliases. - Refactored some tests to use
mainTest.step(...)blocks and added small TS helper types/guards (e.g.,requireMessage). - Added/updated screenshot snapshots for TS specs.
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/dashboard/user-menu.spec.ts | TS version of the user-menu link/navigation assertions. |
| tests/dashboard/user-menu.spec.js | Removed legacy JS spec after TS migration. |
| tests/dashboard/teams/teams-viewer-role.spec.ts | TS migration of viewer role permissions/role-change scenarios; uses screenshots. |
| tests/dashboard/teams/teams-viewer-role.spec.js | Removed legacy JS spec after TS migration. |
| tests/dashboard/teams/teams-viewer-role.spec.ts-snapshots/right-sidebar-image.png | Added snapshot used by the TS viewer-role spec. |
| tests/dashboard/teams/teams-request-access.spec.ts | Migrated to TS with typed helpers/guards and some structural cleanup. |
| tests/dashboard/teams/teams-rename.spec.ts | TS migration of team rename scenarios. |
| tests/dashboard/teams/teams-rename.spec.js | Removed legacy JS spec after TS migration. |
| tests/dashboard/teams/teams-permissions.spec.ts | TS import/style updates for teams permissions tests. |
| tests/dashboard/teams/teams-members.spec.ts | TS migration for member role-change/leave scenarios (contains a blocking fixture-hook issue). |
| tests/dashboard/teams/teams-members.spec.js | Removed legacy JS spec after TS migration. |
| tests/dashboard/teams/teams-management.spec.ts | TS migration of basic team management (create/switch/delete). |
| tests/dashboard/teams/teams-management.spec.js | Removed legacy JS spec after TS migration. |
| tests/dashboard/teams/teams-leave-team.spec.ts | TS migration of leave-team tests (with an overly complex type). |
| tests/dashboard/teams/settings/teams-settings.spec.ts | TS migration of team settings tests using screenshot assertions. |
| tests/dashboard/teams/settings/teams-settings.spec.js | Removed legacy JS spec after TS migration. |
| tests/dashboard/teams/settings/teams-settings.spec.ts-snapshots/team-profile-image.png | Added snapshot used by the TS team-settings spec. |
| tests/dashboard/dashboard-fonts.spec.ts | TS migration of dashboard fonts tests (upload/search/edit/delete flows). |
| tests/dashboard/dashboard-fonts.spec.js | Removed legacy JS spec after TS migration. |
Comments suppressed due to low confidence (2)
tests/dashboard/teams/teams-leave-team.spec.ts:32
- The
pageparameter type forsetupInvitedUseris an overly complex conditional type that always resolves toPageand makes the helper harder to read/maintain. It can be simplified topage: Pagewithout changing behavior.
tests/dashboard/teams/teams-permissions.spec.ts:8 - This file imports
LayersPanelPagewith an explicit.jsextension, but the rest of the TS test suite consistently imports it without the extension. Keeping the import style consistent avoids resolver edge-cases with path aliases and makes refactors easier.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done Definition Checks
Description
This PR migrates dashboard specs to ts. Including snapshots.
How to test
Screenshots 📸