fix(ui): presentational fields skipped in form state when admin.condition is false - #17222
Merged
Conversation
JessRynkar
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
July 7, 2026 10:56
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
jacobsfletch
approved these changes
Jul 8, 2026
JessRynkar
enabled auto-merge (squash)
July 8, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Presentational fields (
row,collapsible, or unnamedgroup) withadmin.conditionset tofalsewere dropped entirely from form state.Why
Regression introduced in #16819 (backport of #16780). It added a short circuit in
addFieldStatePromiseto skip rendering hidden fields. For a presentational field (which holds no value of its own), the early return fired before recursing intofield.fields, so nested field state was never built.Fix
Excludes presentational fields from the early return, letting them fall through to the
fieldHasSubFieldslogic. This allows nested fields to preserve to their values and still skip rendering (they short circuit themselves).Tests
Added to
test/form-stateNOTE: 3.x equivalent of this change here.