fix(server): show GitHub App wrapper failures on the PR panel - #408
Merged
Conversation
The panel mapped every unclassified `gh` exit to "GitHub CLI command failed.", so "app is not installed on pingdotgg/t3code" never reached the UI. Pass through guest wrapper lines (t3-github-app-token / gh-app-wrapper) as the command-failed detail, and keep raw provider stderr off the VCS error message.
patroza
marked this pull request as ready for review
August 15, 2026 08:46
3 tasks
patroza
added a commit
that referenced
this pull request
Aug 15, 2026
## Summary The thread PR panel used the project's primary repository identity. On a fork that prefers **upstream**, so `#410` was loaded as `pingdotgg#410`. That number exists only on the fork: | Repo | #410 | | --- | --- | | `patroza/t3code` | open — docs(agents): drop obsolete fork stack workflow | | `pingdotgg/t3code` | GraphQL: could not resolve | The agent on the left found the fork PR (`gh pr view 410` with `GH_REPO` / origin). The panel asked GitHub for the upstream number and showed **Pull request not found**. This is not the earlier App-install / wrapper issue. Ops #81 and product #408 already landed; t3vm is minting public-read fallback tokens. **Fix:** open the panel from the change-request URL (`patroza/t3code`), and accept any of the checkout's remotes on the server so origin is still this project. ## Test plan - [x] `vp test run apps/server/src/pullRequest/PullRequestService.test.ts apps/web/src/components/pullRequest/pullRequestDetail.logic.test.ts` - [ ] After deploy: open the `#410` thread panel and confirm it loads `#410` - [ ] Confirm an upstream PR on the same checkout still opens against `pingdotgg/t3code` Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR panel mapped every unclassified
ghexit to GitHub CLI command failed., so the real guest-wrapper reason never reached the UI.That is what
#6613(pingdotgg/t3code) showed this time. The live t3vm image already has ops #80 (host-qualified--repo). The product#373shim fix is still onfork/dev. App-only mint dies with:The App is installed on
patroza/macs-holding/effect-app/aaaomega— notpingdotgg.This change passes through guest wrapper lines (
t3-github-app-token:/gh-app-wrapper:) as the command-failed detail, and keeps raw provider stderr off the VCS error message (tokens stay out of logs).Installing the App on
pingdotgg(or using a user/SSH token for those reads) is still required for the panel to actually load that PR.Test plan
vp test run apps/server/src/vcs/VcsProcess.test.ts apps/server/src/sourceControl/GitHubCli.test.tsapp is not installed on …instead of the generic CLI linepatroza/t3codePR still loads on t3vm