Merge upstream/main into fork/dev (15 commits) - #407
Merged
Conversation
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
…ngdotgg#6572) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…ngdotgg#6654) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Nickolas Kyryliuk <nickolaskyryliuk@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
15 upstream commits, fourteen conflicts. The bulk come from pingdotgg#6572 (open remote environments in your local editor over SSH), which lands squarely on surfaces this fork has rewritten. The one that mattered: OpenInPicker. The fork replaced that component wholesale with its own "open with" system (449 lines against upstream's 74), so neither side could win outright. Upstream's remote path is ported into the fork's dispatch instead: for a remote environment, openInEditorMutation launches the editor on the *server*, which is the wrong machine — the viewing machine now gets a Remote-SSH deep link. That matters more here than upstream, since this fork routinely drives several environments at once. Other resolutions: - ElectronShell: upstream moved editor schemes into SAFE_EXTERNAL_PROTOCOLS, which returns any URL carrying one. The fork validates hostname and path first, and that check already permits upstream's `<scheme>://vscode-remote/ssh-remote+…` links, so the fork's two-tier check stays — with the scheme list now derived from upstream's constant rather than hardcoded, so a new remote-capable editor is covered automatically. - LegacySidebar: the shared context after the conflict was the fork's, so upstream's block could not be spliced in; kept the fork's conditional structure and ported upstream's Button migration onto it by hand. - ChatView: took upstream's glass Button styling for scroll-to-end, kept the fork's unread-activity dot and label. - build-desktop-artifact: upstream's pingdotgg#5877 removed WINDOWS_ASAR_UNPACK, so the fork's assertion had no symbol left to assert against; took upstream's. Its linux assertion then exposed a real gap — the fork registered t3code-dev on mac but not linux, while declaring an explicit MimeType. Both now cover the dev scheme. - PortExposure test: pingdotgg#6572 added hasListenerOnHost to NetServiceShape; the fork's stub predated it. - IPC, ws, contracts, ChatHeader, toast, index.css: unions of independent additions, minus the duplicate imports the union produced. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
15 upstream commits, fourteen conflicts. Most come from #6572 (open remote environments in your local editor over SSH), which lands squarely on surfaces this fork has rewritten.
The one that mattered
OpenInPicker. The fork replaced that component wholesale with its own "open with" system — 449 lines against upstream's 74 — so neither side could win outright. Upstream's remote path is ported into the fork'sdispatchinstead:Without it,
openInEditorMutationlaunches the editor on the server — for a remote environment, the wrong machine entirely. That matters more here than upstream, since this fork routinely drives several environments at once.Other resolutions
ElectronShell— upstream moved editor schemes intoSAFE_EXTERNAL_PROTOCOLS, which returns any URL carrying one. The fork validates hostname and path first, and that check already permits upstream's<scheme>://vscode-remote/ssh-remote+…links, so the fork's stricter two-tier check stays — with the scheme list now derived from upstream'sREMOTE_CAPABLE_EDITOR_IDSinstead of hardcoded, so a new remote-capable editor is covered without another edit.LegacySidebar— the shared context after the conflict was the fork's, so upstream's block could not be spliced in without breaking indentation and duplicating the Add-project button. Kept the fork's conditional structure and ported upstream'sButtonmigration onto it by hand.ChatView— upstream's glassButtonstyling for scroll-to-end, with the fork's unread-activity dot and label.build-desktop-artifact— upstream's #5877 removedWINDOWS_ASAR_UNPACK, so the fork's assertion had no symbol left to assert against; took upstream's. Its linux assertion then exposed a real gap: the fork registeredt3code-devon mac but not linux, while also declaring an explicitMimeType. Both now cover the dev scheme, so dev deep links work on Linux.PortExposuretest — feat(web): open remote environments in your local editor over SSH pingdotgg/t3code#6572 addedhasListenerOnHosttoNetServiceShape; the fork's stub predated it.EditorId,ClientSettings,BackgroundPolicy,FileSystem), each of which typecheck caught.Verification
All 15 upstream commits checked by comparing each commit's added lines against the merged tree. Thirteen are 100% present. Two flagged, both explained:
d7abd7f3breports 21% — it was reverted upstream by804cba430in this same range, so its absence is correct.57a299a78(feat(web): open remote environments in your local editor over SSH pingdotgg/t3code#6572) reports 89% — the missing lines are upstream'sOpenInPickerrewrite, deliberately not taken; its behaviour is present atOpenInPicker.tsx:391-399.pnpm typecheck0 errors ·pnpm test— 278 files pass ·vp buildinapps/web·vp check --fix.One known flake:
PreviewFaviconIcon.test.tsxfails under parallel load and passes in isolation (verified twice). Pre-existing, unrelated to this merge.Merge with
gh pr merge 405 --merge, not the button — the squash default cost us the upstream lineage on #401.Co-authored-by: Patrick Roza 42661+patroza@users.noreply.github.com
🤖 Generated with Claude Code via T3 Chat on Discord