ui: Handle Query.parse inputs without a profile-type prefix#6346
Merged
Conversation
|
✅ Meticulous spotted 0 visual differences across 288 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit |
metalmatze
force-pushed
the
ui-parser-bare-matchers
branch
from
May 4, 2026 16:25
0e8efbe to
1d01604
Compare
brancz
approved these changes
May 4, 2026
metalmatze
force-pushed
the
ui-parser-bare-matchers
branch
2 times, most recently
from
May 4, 2026 16:31
f0d477b to
54fe692
Compare
metalmatze
force-pushed
the
ui-parser-bare-matchers
branch
from
May 4, 2026 16:36
54fe692 to
9181dd2
Compare
Bare matcher inputs like `{namespace=~"a", pod=~".*"}` match the
`_ matchers _` grammar rule, which returns `profileName: {}`. Both
Query.fromAst and the partial-parse fallback then crashed when
constructing the ProfileType from the missing value. Default to an
empty ProfileType in both paths.
metalmatze
force-pushed
the
ui-parser-bare-matchers
branch
from
May 4, 2026 16:40
9181dd2 to
ef022fd
Compare
metalmatze
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare matcher inputs like
{namespace=~"a", pod=~".*"}match the_ matchers _grammar rule, which returnsprofileName: {}. BothQuery.fromAstand the partial-parse fallback then crash on undefined when constructing theProfileTypefrom the missing value, taking down callers likeProfileSelector. Default to an emptyProfileTypein both paths.