Skip to content

ui: Sumby handle the URL param values correctly in the profile-type change effect #6221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yomete merged 3 commits into from
Mar 3, 2026
Merged

ui: Sumby handle the URL param values correctly in the profile-type change effect #6221

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43d6a6b
Sumby handle the URL param values correctly in the profile-type chang…
manojVivek Mar 3, 2026
e407498
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Mar 3, 2026
d055dad
reword
yomete Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ui/packages/shared/profile/src/useSumBy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,14 @@ export const useSumBySelection = (
}
}

// Prefer non-empty URL default over auto-computed default to avoid a
// one-render race where defaultSumBy overwrites the default value from upstream.
const hasExplicitDefault = defaultValue != null && defaultValue.length > 0;
let result =
userSelectedSumBy[profileType?.toString() ?? ''] ?? defaultSumBy ?? DEFAULT_EMPTY_SUM_BY;
userSelectedSumBy[profileType?.toString() ?? ''] ??
(hasExplicitDefault ? defaultValue : undefined) ??
defaultSumBy ??
DEFAULT_EMPTY_SUM_BY;

if (profileType?.delta !== true) {
result = DEFAULT_EMPTY_SUM_BY;
Expand All @@ -123,7 +129,7 @@ export const useSumBySelection = (
lastValidSumByRef.current = result;

return result;
}, [userSelectedSumBy, profileType, defaultSumBy, labelNamesLoading, draftSumBy]);
}, [userSelectedSumBy, profileType, defaultSumBy, labelNamesLoading, draftSumBy, defaultValue]);

return [
sumBy,
Expand Down Expand Up @@ -266,7 +272,11 @@ export const useDraftSumBy = (
const {defaultSumBy, isLoading} = useDefaultSumBy(profileType, labelNamesLoading, labels);

return {
draftSumBy: draftSumBy ?? defaultSumBy ?? DEFAULT_EMPTY_SUM_BY,
draftSumBy:
draftSumBy ??
(defaultValue != null && defaultValue.length > 0 ? defaultValue : undefined) ??
defaultSumBy ??
DEFAULT_EMPTY_SUM_BY,
setDraftSumBy,
isDraftSumByLoading: isLoading,
};
Expand Down
Loading