Skip to content

ui: Pass disabled state to Listbox and update styles #6207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yomete merged 1 commit into from
Feb 18, 2026
Merged

ui: Pass disabled state to Listbox and update styles #6207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/packages/shared/components/src/Select/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
element: SelectElement;
}

export function contructItemsFromArray(items: any[]): SelectItem[] {

Check warning on line 33 in ui/packages/shared/components/src/Select/index.tsx

View workflow job for this annotation

GitHub Actions / UI Test and Lint 

Unexpected any. Specify a different type
return items.map(item => ({
key: item.key,
element: {active: <>{item.label}</>, expanded: <>{item.label}</>},
Expand Down Expand Up @@ -80,15 +80,15 @@
'text-gray-100 dark:gray-900 bg-indigo-600 border-indigo-500 font-medium py-2 px-4 focus:ring-indigo-500 focus:border-indigo-500';

return (
<Listbox value={selectedKey} onChange={onSelection}>
<Listbox value={selectedKey} onChange={onSelection} disabled={disabled}>
{({open}) => (
<div className="relative">
<div id={id}>
<Listbox.Button
className={cx(
styles,
width !== undefined ? `w-${width}` : 'w-full',
disabled ? 'cursor-not-allowed pointer-events-none' : '',
disabled ? 'opacity-50 cursor-not-allowed' : '',
primary ? primaryStyles : defaultStyles,
{[className]: className.length > 0}
)}
Expand Down
Loading