Skip to content

ui: Compare close button test id #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manojVivek merged 2 commits into from
Sep 16, 2025
Merged

ui: Compare close button test id #5957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9532617
Compare close button test id
manojVivek Sep 16, 2025
123e43f
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ui/packages/shared/profile/src/ProfileSelector/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
} from '@parca/components';
import {CloseIcon} from '@parca/icons';
import {Query} from '@parca/parser';
import {TEST_IDS, testId} from '@parca/test-utils';
import {type NavigateFunction} from '@parca/utilities';

import {ProfileSelection} from '..';
Expand Down Expand Up @@ -331,7 +332,11 @@ const ProfileSelector = ({
/>
{comparing && (
<div>
<IconButton onClick={() => closeProfile()} icon={<CloseIcon />} />
<IconButton
onClick={() => closeProfile()}
icon={<CloseIcon />}
{...testId(TEST_IDS.COMPARE_CLOSE_BUTTON)}
/>
</div>
)}
</div>
Expand Down
1 change: 1 addition & 0 deletions ui/packages/shared/test-utils/src/test-ids.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export const TEST_IDS = {
COMPARE_SIDE_A: 'compare-side-a',
COMPARE_SIDE_B: 'compare-side-b',
COMPARE_PROFILE_VIEW: 'compare-profile-view',
COMPARE_CLOSE_BUTTON: 'compare-close-button',

// Diff Legend
DIFF_LEGEND: 'diff-legend',
Expand Down
Loading