Skip to content

refactor: Scrape loop.#5945

Merged
thorfour merged 2 commits into
mainfrom
fix-scrape-interval-on-error
Sep 9, 2025
Merged

refactor: Scrape loop.#5945
thorfour merged 2 commits into
mainfrom
fix-scrape-interval-on-error

Conversation

@thorfour

@thorfour thorfour commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Previously when the scrape suceeded but the function was unable to parse the result 'continue' was called which made it immediately try again since the ticker is only waited upon at the end of the loop. This can cause a huge rps spike if the endpoint is always returning invalid profiling data.

This moves the processing of the response code to a function instead that returns an error, and if an error is encountered it handles it and drops into the second select in the loop to prevent rapid reties.

Previously when the scrape suceeded but the function was unable to parse
the result 'continue' was called which made it immediately try again
since the ticker is only waited upon at the end of the loop. This can
cause a huge rps spike if the endpoint is always returning invalid
profiling data.

This moves the processing of the response code to a function instead
that returns an error, and if an error is encountered it handles it and
drops into the second select in the loop to prevent rapid reties.
@alwaysmeticulous

alwaysmeticulous Bot commented Sep 9, 2025

Copy link
Copy Markdown

✅ Meticulous spotted 0 visual differences across 503 screens tested: view results.

Meticulous evaluated ~4 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit f806d93. This comment will update as new commits are pushed.

@thorfour
thorfour enabled auto-merge (squash) September 9, 2025 13:04
@thorfour
thorfour merged commit 0caaf60 into main Sep 9, 2025
35 checks passed
@thorfour
thorfour deleted the fix-scrape-interval-on-error branch September 9, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants