Skip to content

feat(debuginfo-upload): add signed requests support for s3#5923

Merged
brancz merged 2 commits into
parca-dev:mainfrom
iamKunal:main
Sep 18, 2025
Merged

feat(debuginfo-upload): add signed requests support for s3#5923
brancz merged 2 commits into
parca-dev:mainfrom
iamKunal:main

Conversation

@iamKunal

@iamKunal iamKunal commented Aug 26, 2025

Copy link
Copy Markdown

Adds signed url support to upload debuginfo to S3

@CLAassistant

CLAassistant commented Aug 26, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@iamKunal
iamKunal marked this pull request as ready for review September 17, 2025 20:04
@iamKunal
iamKunal requested a review from a team as a code owner September 17, 2025 20:04

@thorfour thorfour left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamKunalGupta

Copy link
Copy Markdown
Contributor

Please let me know if you need anything else from me. The lint failures are outside the changed files

@brancz
brancz merged commit d99ff62 into parca-dev:main Sep 18, 2025
32 of 34 checks passed
@brancz

brancz commented Sep 18, 2025

Copy link
Copy Markdown
Member

was just waiting for CI to run :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants