Skip to content

feat(debuginfo): implement ObjectSizer interface for UploadReader #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brancz merged 1 commit into from
May 21, 2025
Merged

feat(debuginfo): implement ObjectSizer interface for UploadReader #5641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/debuginfo/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,9 @@ func contextError(ctx context.Context) error {
return nil
}
}

// ObjectSize implements the objstore.ObjectSizer interface to provide the total size of bytes read so far.
// This is used by objstore.TryToGetSize to optimize multipart uploads by pre-allocating the correct buffer size.
func (r *UploadReader) ObjectSize() (int64, error) {
return int64(r.size), nil
}