Skip to content

area/ui: strip attributes from context menu #5539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yomete merged 2 commits into from
Feb 25, 2025
Merged

area/ui: strip attributes from context menu #5539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f2e829
area/ui: strip attributes from context menu
yomete Feb 25, 2025
767da57
Merge branch 'main' into utilization-context-menu
yomete Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ui/packages/shared/profile/src/MetricsGraph/MetricsContextMenu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,12 @@ const MetricsContextMenu = ({
<Item
key={label.name}
id={label.name}
onClick={() => onAddLabelMatcher({key: label.name, value: label.value})}
onClick={() => {
onAddLabelMatcher({
key: transformUtilizationLabels(label.name, utilizationMetrics),
value: label.value,
});
}}
className="max-w-[400px] overflow-hidden"
>
<div className="mr-3 inline-block rounded-lg bg-gray-200 px-2 py-1 text-xs font-bold text-gray-700 dark:bg-gray-700 dark:text-gray-300">
Expand Down
13 changes: 7 additions & 6 deletions ui/packages/shared/profile/src/MetricsGraph/UtilizationMetrics/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,14 +446,15 @@ const RawUtilizationMetrics = ({
<g className="lines fill-transparent">
{series.map((s, i) => {
let isSelected = false;
if (
selectedSeriesMatchers != null &&
selectedSeriesMatchers.length > 0 &&
selectedSeriesMatchers.length === s.metric.length
) {
if (selectedSeriesMatchers != null && selectedSeriesMatchers.length > 0) {
isSelected = selectedSeriesMatchers.every(m => {
for (let i = 0; i < s.metric.length; i++) {
if (s.metric[i].name === m.key && s.metric[i].value === m.value) {
if (
s.metric[i].name
.replace('attributes_resource.', '')
.replace('attributes.', '') === m.key &&
s.metric[i].value === m.value
) {
return true;
}
}
Expand Down