Skip to content

ui: Icicle chart minor UX tweaks #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manojVivek merged 3 commits into from
Feb 25, 2025
Merged

ui: Icicle chart minor UX tweaks #5537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad575d6
Hiding the 'root' node from the stacks in flamecharts as it doesn't s…
manojVivek Feb 25, 2025
7513470
Disable clicks in flamecharts
manojVivek Feb 25, 2025
0de5293
Linter fix
manojVivek Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleChartRootNode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@

import React, {Fragment} from 'react';

import cx from 'classnames';
import twColors from 'tailwindcss/colors';

import {scaleLinear} from '@parca/utilities';

import {FIELD_CHILDREN, FIELD_CUMULATIVE, FIELD_DURATION, FIELD_TIMESTAMP} from '.';
Expand All @@ -33,7 +30,6 @@ export const IcicleChartRootNode = React.memo(function IcicleChartRootNodeNonMem
colors,
colorBy,
y,
height,
setCurPath,
curPath,
level,
Expand Down Expand Up @@ -96,30 +92,13 @@ export const IcicleChartRootNode = React.memo(function IcicleChartRootNodeNonMem

return (
<Fragment key={row}>
<g transform={`translate(${x + 1}, ${y + 1})`}>
<rect
x={0}
y={0}
width={width}
height={RowHeight}
style={{
fill: darkMode ? twColors.gray[500] : twColors.gray[200],
}}
className={cx(`stroke-white dark:stroke-gray-700 fill-gray-600 dark:fill-gray-100`)}
/>
<svg width={width - 5} height={height}>
<text x={5} y={15} style={{fontSize: '12px'}}>
root
</text>
</svg>
</g>
<IcicleNode
table={table}
row={row}
colors={colors}
colorBy={colorBy}
x={x}
y={RowHeight}
y={y}
totalWidth={width ?? 1}
height={RowHeight}
setCurPath={setCurPath}
Expand Down
2 changes: 1 addition & 1 deletion ui/packages/shared/profile/src/ProfileView/components/DashboardItems/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const getDashboardItem = ({
return (
<ProfileIcicleGraph
curPath={curPath}
setNewCurPath={setNewCurPath}
setNewCurPath={() => {}}
arrow={flamechartData?.arrow}
total={total}
filtered={filtered}
Expand Down