Skip to content

fix(ui): Remove .env commited by accident in #4612#5535

Merged
yomete merged 2 commits into
parca-dev:mainfrom
mmkay:fix/remove-env
Feb 24, 2025
Merged

fix(ui): Remove .env commited by accident in #4612#5535
yomete merged 2 commits into
parca-dev:mainfrom
mmkay:fix/remove-env

Conversation

@mmkay

@mmkay mmkay commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Issue

We were testing out the new 0.23.0 release and found out that when we try to deploy the Docker image in a charm, parca starts, but the UI isn't able to reach the backend:

Screenshot from 2025-02-24 13-53-26

Troubleshooting

It looks like the UI is trying to reach the backend at localhost:7070:

Screenshot from 2025-02-24 13-46-26

This path also appears in the minified sources:

Screenshot from 2025-02-24 13-46-37

My guess is that it's coming from an .env file that's part of PR #4612: https://github.com/parca-dev/parca/pull/4612/files#diff-a87fe5ff9949176705be7bff417acf6bec9355fdda9d1bc0fa9c8910e5666381R1 - given the whole PR is mostly bumping dependencies, I assume this was added by accident.

Solution

Remove the .env file. It looks like for the docker images to work, a new release might be needed.

@mmkay
mmkay requested a review from a team as a code owner February 24, 2025 12:57
@CLAassistant

CLAassistant commented Feb 24, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@yomete
yomete enabled auto-merge February 24, 2025 13:13

@yomete yomete left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @mmkay
We'll merge this in and cut a new release so that Docker images can start working again.

auto-merge was automatically disabled February 24, 2025 13:15

Head branch was pushed to by a user without write access

@mmkay

mmkay commented Feb 24, 2025

Copy link
Copy Markdown
Contributor Author

Thanks! @mmkay We'll merge this in and cut a new release so that Docker images can start working again.

Thanks @yomete ! I just added this file to .gitignore too so it doesn't re-appear.

@yomete

yomete commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

@mmkay we've now released 0.23.1. Please check it out and let us know if everything works alright.

@mmkay

mmkay commented Feb 25, 2025

Copy link
Copy Markdown
Contributor Author

@yomete thanks for letting know! I tested the new docker image yesterday and the issue was gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants