symbolizer: reduce the number of debuginfo copies#5330
Merged
brancz merged 1 commit intoJan 16, 2025
Conversation
brancz
reviewed
Dec 6, 2024
brancz
left a comment
brancz
left a comment
Member
There was a problem hiding this comment.
this needs a go fmt as well, otherwise the strategy lgtm
danipozo
force-pushed
the
reduce-debuginfo-copies-when-symbolizing
branch
from
December 9, 2024 10:48
4762250 to
a2198b8
Compare
danipozo
force-pushed
the
reduce-debuginfo-copies-when-symbolizing
branch
from
December 12, 2024 10:12
a2198b8 to
4c37617
Compare
Member
|
Not sure why CI isn't running on this PR. Can you rebase maybe and see if that re-triggers CI? |
danipozo
force-pushed
the
reduce-debuginfo-copies-when-symbolizing
branch
from
January 14, 2025 14:47
4c37617 to
9c2998f
Compare
Contributor
Author
|
Rebased but it's not triggering the CI |
Member
|
Looks like it's running now! |
Member
|
One small thing the linter is complaining about, then I think this is ready to merge. |
danipozo
force-pushed
the
reduce-debuginfo-copies-when-symbolizing
branch
from
January 15, 2025 15:46
9c2998f to
7b9e359
Compare
Contributor
Author
|
Seems like Go / Test on arm64 timed out |
Member
|
Merged, that job is not very reliable and super slow and I don't want to slow this down further since I don't think this is any different for arm64 and x86. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the existence of debuginfo files in the temporary directory to reduce the number of copies on each request, which drives high disk usage and latency.