Skip to content

area/ui: rejig dashboard buttons#5276

Merged
yomete merged 5 commits into
mainfrom
rejig-dashboard-buttons
Nov 18, 2024
Merged

area/ui: rejig dashboard buttons#5276
yomete merged 5 commits into
mainfrom
rejig-dashboard-buttons

Conversation

@yomete

@yomete yomete commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

This is a PR that restructures the toolbar buttons.

Summary:

  • The "Sort by" button is moved within the context of the icicle graph.
  • The "Table columns" button is moved within the context of the table component.
  • The table component now has a column to display the color which can either be the filename or binary.
  • Hiding binaries now works with the table component
  • The color legend is now above both the icicle and table visualisations. it was previously located above the icicle viz only.

@yomete
yomete requested a review from a team as a code owner November 7, 2024 14:55
@alwaysmeticulous

alwaysmeticulous Bot commented Nov 7, 2024

Copy link
Copy Markdown

🤖 Meticulous spotted visual differences in 214 of 306 screens tested: view and approve differences detected.

Meticulous simulated ~4 hours of user flows against your PR.

Last updated for commit 48e967f. This comment will update as new commits are pushed.

@yomete yomete changed the title area/ui: rejig dashboard buttons (wip) area/ui: rejig dashboard buttons Nov 13, 2024

@manojVivek manojVivek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@yomete
yomete merged commit c378906 into main Nov 18, 2024
@yomete
yomete deleted the rejig-dashboard-buttons branch November 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants