bug fix: Clicking on a sample should highlight it when there are query filters and sum by values#5054
Merged
Merged
Conversation
…y filters and sum by values
|
🤖 Meticulous spotted visual differences in 4 of 589 screens tested: view and approve differences detected. Last updated for commit d803854. This comment will update as new commits are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When profiling data is filtered with both matchers and sumBy value(s), selecting a profile in the metrics graph fails to highlight the point.
Steps to reproduce:
This is happening because the
findSelectedProfilefunction uses label matchers from the query expression to determinethe selected series. With sumBy, series are limited to the sumBy value, causing the function to fail as it looks for non-existent label sets.
The fix here ensures that we are correctly identifying the selected series based on the profile matchers alone or a combination of the profile matchers and the sumBy value (and prioritizing the sumBy label names and values if present).