cargo: remove features#62
Closed
lovesegfault wants to merge 1 commit into
Closed
Conversation
The justification for them existing was that cargo adds in binary-only deps to mixed bin/lib crates, which inflates dependency trees and overall just sucks. While this is true, that doesn't apply to dev-dependencies, which don't get propagated, but which are available to example code. By removing the myriad of features and moving those dependencies into `dev-dependencies` we make developers' lives easier (it's easier to run examples) and don't actually lose anything. Moreover, this also allows to test all code with no need for `--all-features`.
|
This means that all dependencies required for specific examples will be build when you try to build any of the examples. |
Contributor
Author
|
That's correct, the difference is actually small and the gain in convenience of not having to deal with all the feature flags is huge. |
Owner
|
I want to move the examples to their own crates so we don't have dependency bloat. The features were introduced because I didn't want to build e.g. all of the SDL dependencies on the |
Contributor
Author
|
Understood, I'll do that in a separate PR then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The justification for them existing was that cargo adds in binary-only
deps to mixed bin/lib crates, which inflates dependency trees and
overall just sucks.
While this is true, that doesn't apply to dev-dependencies, which don't
get propagated, but which are available to example code. By removing the
myriad of features and moving those dependencies into
dev-dependencieswe make developers' lives easier (it's easier to run examples) and don't
actually lose anything.
Moreover, this also allows to test all code with no need for
--all-features.