Skip to content

ci: move to github actions#61

Merged
parasyte merged 1 commit into
parasyte:masterfrom
lovesegfault:gh-actions
Apr 13, 2020
Merged

ci: move to github actions#61
parasyte merged 1 commit into
parasyte:masterfrom
lovesegfault:gh-actions

Conversation

@lovesegfault

Copy link
Copy Markdown
Contributor

This allows us to use all the nice things from GH actions and actions-rs

@lovesegfault

lovesegfault commented Apr 13, 2020

Copy link
Copy Markdown
Contributor Author

Given the discussion in #60 I'll be adding an MSRV check

@parasyte

Copy link
Copy Markdown
Owner

Some other things would be really nice to have here:

  1. Should allow failures on nightly
  2. Perform weekly builds with on.schedule to avoid bitrot.
  3. check should run cargo fmt --all -- --check and cargo doc --workspace --no-deps to enforce formatting and docs best practices. (I see fmt is in lints ... might be fine there)
  4. lints should run cargo clippy --all --tests -- -D warnings to deny warnings

@lovesegfault

Copy link
Copy Markdown
Contributor Author

@parasyte I can't figure out how to allow failures, would you rather have a blocking nightly or no nightly?

@lovesegfault

Copy link
Copy Markdown
Contributor Author

Alright, I think I got all other requests done :)

@parasyte

Copy link
Copy Markdown
Owner

Hmmm, good question! I guess I would rather remove nightly, sadly. There is https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error but it looks like you will have to create separate checks tests jobs for nightly with this.

@lovesegfault

Copy link
Copy Markdown
Contributor Author

Alright, I fixed the syntax errors :)

@lovesegfault

Copy link
Copy Markdown
Contributor Author

@parasyte After you merge this, please remember to update the badge in the README, I can't get the correct link until this is merged and the actions window shows up :)

parasyte
parasyte previously approved these changes Apr 13, 2020
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated

@parasyte parasyte left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll give it a try.

@parasyte parasyte merged commit d88b452 into parasyte:master Apr 13, 2020
@lovesegfault lovesegfault deleted the gh-actions branch April 14, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants