fix(net): preserve ECIESError in connect_without_timeout - #19558
Merged
mattsse merged 2 commits intoNov 6, 2025
Conversation
CodSpeed Performance ReportMerging #19558 will improve performances by 10.87%Comparing Summary
Benchmarks breakdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ECIESStream::connect_without_timeout() remapped any error from ECIESCodec::new_client() to io::Error::other("invalid handshake"), which collapsed structured ECIESError variants (e.g., Secp256k1) into a generic IO error.
This broke downstream error classification in the networking layer, which matches on ECIESErrorImpl variants to decide on backoff and whether a failure is fatal.
Changes:
variant is ECIESErrorImpl::Secp256k1(_), not IO.
This aligns client error handling with server-side incoming() and ensures consistent, actionable error semantics for callers.